Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test-native-image.sh #3386

Merged
merged 18 commits into from
Oct 8, 2021
Merged

Add test-native-image.sh #3386

merged 18 commits into from
Oct 8, 2021

Conversation

barchetta
Copy link
Member

@barchetta barchetta commented Sep 7, 2021 •
edited
Loading

Further work on #920

Will fail pipeline until #3385 is merged.

@barchetta barchetta added this to the 2.4.0 milestone Sep 7, 2021
@barchetta barchetta self-assigned this Sep 7, 2021
@barchetta barchetta marked this pull request as ready for review September 7, 2021 23:48
romain-grecourt
romain-grecourt reviewed Sep 8, 2021
View reviewed changes
Copy link
Contributor

@romain-grecourt romain-grecourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

barchetta and others added 6 commits September 10, 2021 11:14
@barchetta
Merge remote-tracking branch 'upstream/master' into native-image-test
b47c134
@tomas-langer
squashable
d35cf6e 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
squashable
866fe63 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Test other packaging
5327f25 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Removed mp-2 native build.
acaa5dd 
Moved native as last test, to validate jar and jlink.

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Added -e to see stacktrace.
07b4e99 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Copy link
Member

This requires build tools 2.2.4 - there is a problem with a race condition in the ProcessMonitor that fails if the process finishes too fast, which happens quite often when showing the -help output of the start command of JLink.

@romain-grecourt
Uptake latest build-tools
42ab78b 
Note that it's using the staging profile to pull build-tools 2.3.0 from the staging repository, this is only for testing and should be removed before merging.
@romain-grecourt romain-grecourt merged commit 8704b5d into helidon-io:master Oct 8, 2021
@barchetta barchetta deleted the native-image-test branch November 2, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romain-grecourt romain-grecourt romain-grecourt approved these changes

@tomas-langer tomas-langer Awaiting requested review from tomas-langer

Assignees

@barchetta barchetta

@tomas-langer tomas-langer

Labels
native-image testing
Projects
Backlog
Archived in project
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@barchetta @tomas-langer @romain-grecourt