Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New section describing Helidon/JAX-RS integration #3554

Merged
merged 4 commits into from
Oct 21, 2021
Merged

New section describing Helidon/JAX-RS integration #3554

merged 4 commits into from
Oct 21, 2021

Conversation

spericas
Copy link
Member

@spericas spericas commented Oct 14, 2021 •
edited
Loading

New section that describes the JAX-RS/Helidon integration layer, including support for 0 or more JAX-RS applications, discovery and how to access application instances. Relates to issue #3482.

@spericas
New document that describes how Helidon's support for 0 or more JAX-R…
c315a42 
…S applications.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas
New section that describes the JAX-RS/Helidon integration layer, incl…
412dcad 
…uding support for 0 or more JAX-RS applications and how to access application instances.
@spericas
Removed trailing white space.
729f006
@spericas spericas added the docs label Oct 14, 2021
@spericas spericas added this to the 2.4.0 milestone Oct 14, 2021
@spericas spericas self-assigned this Oct 14, 2021
@spericas spericas mentioned this pull request Oct 14, 2021
Closed
ljamen
ljamen reviewed Oct 20, 2021
View reviewed changes
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really good. My only (optional) suggestion is to use heading case with Level 2 headers (cap init each major word).

@tomas-langer
Copy link
Member

I think it would be great to highlight that the Application subclass should be annotated with @ApplicationScoped - maybe add an example. We have problems reported for that (such as when using JwtAuth which requires an application)

@spericas
Copy link
Member Author

@ljamen I did think about it, but noticed no other doc in that section was following that convention. I will update the doc.

@spericas
Copy link
Member Author

I think it would be great to highlight that the Application subclass should be annotated with @ApplicationScoped - maybe add an example. We have problems reported for that (such as when using JwtAuth which requires an application)

I'm assuming you mean for discovery purposes. Good point!

@spericas
Explained discovery of Application subclasses based on CDI's discover…
f2b9c3f 
…y mode. A few other minor changes.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas requested a review from ljamen October 20, 2021 17:29
@spericas
Copy link
Member Author

@tomas-langer @ljamen Document updated based on feedback.

tomas-langer
tomas-langer approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spericas spericas merged commit 077dd20 into helidon-io:master Oct 21, 2021
@spericas spericas mentioned this pull request Oct 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-langer tomas-langer tomas-langer approved these changes

@ljamen ljamen Awaiting requested review from ljamen

Assignees

@spericas spericas

Labels
docs
Projects
Backlog
Archived in project
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@spericas @tomas-langer @ljamen