Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrades Netty to 4.1.72.Final #3739

Merged
merged 3 commits into from
Dec 14, 2021
Merged

Upgrades Netty to 4.1.72.Final #3739

merged 3 commits into from
Dec 14, 2021

Conversation

ljnelson
Copy link
Member

Signed-off-by: Laird Nelson laird.nelson@oracle.com

@ljnelson
Upgrades Netty to 4.1.72.Final
27e7b38 
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
@ljnelson ljnelson added 2.x Issues for 2.x version branch dependencies Pull requests that update a dependency file labels Dec 14, 2021
@ljnelson ljnelson requested a review from barchetta December 14, 2021 01:53
@ljnelson ljnelson self-assigned this Dec 14, 2021
@ljnelson
Copy link
Member Author

2.x backport of #3738

@ljnelson ljnelson mentioned this pull request Dec 14, 2021
Closed
@ljnelson
Squashable commit; fixing errors
e4a8ad5 
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
@barchetta barchetta added this to the 2.4.1 milestone Dec 14, 2021
@ljnelson
Squashable commit; native-image.properties on the 2.x branch needs on…
86b5f8f 
…e initialize-at-runtime instruction removed

Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
@ljnelson
Copy link
Member Author

I had to remove an initialize-at-runtime instruction from native-image.properties to make the mp-1 test pass on my machine, but only on the helidon-2.x branch. If I were to omit the same instruction from the 3.x branch, I believe that a different native image test would fail there (or I wouldn't have added the line in the master branch PR in the first place). I hope someone can take a look and make sense of this.

@ljnelson ljnelson merged commit 0b31035 into helidon-io:helidon-2.x Dec 14, 2021
@ljnelson ljnelson deleted the upgrade-netty-to-4.1.72.Final-2.x-backport branch December 14, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barchetta barchetta barchetta approved these changes

Assignees

@ljnelson ljnelson

Labels
2.x Issues for 2.x version branch dependencies Pull requests that update a dependency file
Projects
Backlog
Archived in project
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ljnelson @barchetta