Only deactivate request context if it was inactive before migrating it #3813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… calling the resource method. Jersey may still need to have the context active for allocation of providers such as writer interceptors. Instead, request context state will be overwritten simply next time the thread is reused and another context migrated. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
…s inactive. New interceptor in test. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
spericas
changed the title
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
tjquinno
previously approved these changes
Jan 19, 2022
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
tjquinno
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not eagerly restore a migrated request context in new thread after calling the resource method. Jersey may still need to have the context active for allocation of providers such as writer interceptors. Instead, request context state will be overwritten simply next time the thread is reused and another context migrated. See issue #3810.