Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x Fix deps in jpa examples and do other cleanup #4132

Merged
merged 3 commits into from
Apr 15, 2022

Conversation

barchetta
Copy link
Member

The pokemons and jpa examples failed to run from the command line due to dependency issues. Fixed the following:

  • Changed jpa and jta dependencies to compile (from provided). Added bean validation since hibernate seemed to want that
  • Removed comment from init_script.sql since H2 was trying to parse the comment block as SQL. It skipped it (so test passed) but generated lots of exceptions in log
  • Exclude .sql files from copyright check so we are not lured into making mistake again
  • README edits
  • Jakarta-fy persistence.xml

@barchetta barchetta added examples jpa/jta 3.x Issues for 3.x version branch labels Apr 14, 2022
@barchetta barchetta requested review from ljnelson and spericas April 14, 2022 23:13
@barchetta barchetta self-assigned this Apr 14, 2022
Copy link
Member

@ljnelson ljnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few references left to 2.2; I think they need to go to 3.0.

@barchetta barchetta requested a review from ljnelson April 15, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issues for 3.x version branch examples jpa/jta
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants