2.x: possible fix for HttpPipelineTest hang #4139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barchetta
changed the title
ljnelson
reviewed
Apr 19, 2022
webserver/webserver/src/test/java/io/helidon/webserver/utils/SocketHttpClient.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a possible fix for #3301.
The test class
SocketHttpClientwas creating a newBufferedReaderevery time it'sreceive()method was called. This could potentially loose bytes since an undetermined number of bytes could be read and buffered off of the socket, only to be discarded when theBufferedReaderwas tossed on the garbage heap.Or at least that is my theory. The test seems more stable after this fix.