docs overview page, reworked intro page #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barchetta
approved these changes
Feb 16, 2019
|
@kumar-dhanagopal Can you review this please ? |
|
@romain-grecourt - It appears from your earlier comment that only docs/src/main/docs/about/02_introduction.adoc has changes that I should review. Pls confirm. |
Both should be reviewed, some of the text in the new overview page is re-used and modified some is new. |
|
I reviewed docs/src/main/docs/about/01_overview.adoc and docs/src/main/docs/about/02_introduction.adoc, and posted my feedback. Let me know if I should review any other doc. |
|
Thanks, I've incorporated all reviews. Will merge when the pipeline passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add docs/src/main/docs/about/01_overview.adoc
Reworked docs/src/main/docs/about/02_introduction.adoc
update sitegen to 1.0.8
renamed docs/src/main/docs/tracing/01_tracing.adoc to lowercase only
renamed docs/src/main/docs/tracing/02_zipkin.adoc to lowercase only
removed empty line in docs/src/main/docs/guides/01_overview.adoc