-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added X509 certificate context key when client certificate is present and pem trust store configuration #4185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astromechza
force-pushed
the
client-mtls-2752
branch
3 times, most recently
from
May 9, 2022 09:55
99bc0e8
to
ae9d697
Compare
astromechza
changed the title
[WIP] Added X509 certificate context key when client certificate is present
Added X509 certificate context key when client certificate is present and pem trust store configuration
May 9, 2022
astromechza
force-pushed
the
client-mtls-2752
branch
7 times, most recently
from
May 9, 2022 13:33
62070ec
to
954b0dd
Compare
/oca-checked |
/trigger |
astromechza
force-pushed
the
client-mtls-2752
branch
from
May 9, 2022 16:37
954b0dd
to
75be524
Compare
astromechza
force-pushed
the
client-mtls-2752
branch
from
May 10, 2022 08:12
75be524
to
32eca6a
Compare
Fixing checkstyle.. pr ammended |
webserver/webserver/src/main/java/io/helidon/webserver/ForwardingHandler.java
Show resolved
Hide resolved
/trigger |
tomas-langer
approved these changes
May 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
webserver/webserver/src/main/java/io/helidon/webserver/ForwardingHandler.java
Show resolved
Hide resolved
Verdent
approved these changes
May 16, 2022
@astromechza Thank you for your contribution! |
astromechza
added a commit
to astromechza/helidon
that referenced
this pull request
May 18, 2022
trentjeff
pushed a commit
that referenced
this pull request
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some additional support for mTLS based workloads:
A new unittest class was added to add rapid testing of MTLS and (1) was done to support the testing of (2) using the self-signed certificate already present in the test resources.
Resolves #2752 and resolves #3279