Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New AnnotationFinder to handle transitive annotations in FT #4216

Merged
merged 5 commits into from
May 18, 2022

Conversation

spericas
Copy link
Member

New AnnotationFinder to handle transitive annotations in FT used by interceptor bindings. This allows users to define new annotations that are themselves annotated with FT annotations to be used. See new tests and Issue 4171.

Signed-off-by: Santiago Pericasgeertsen santiago.pericasgeertsen@oracle.com

…nterceptor bindings. This allows users to define new annotations that are themselves annotated with FT annotations to be used. See new tests and Issue 4171.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas added this to the 2.5.1 milestone May 13, 2022
@spericas spericas requested a review from ljnelson May 13, 2022 13:46
@spericas spericas self-assigned this May 13, 2022
ljnelson
ljnelson previously approved these changes May 16, 2022
Copy link
Member

@ljnelson ljnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp approval for now due to urgency; this will not work in many edge scenarios involving other extensions redefining interceptor bindings, designating other annotations as interceptor bindings, etc.

…d of the corresponding Java classes.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
…n manager when available.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas requested a review from ljnelson May 18, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants