Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

first perf fixes #423

Merged
merged 1 commit into from
Feb 19, 2019
Merged

first perf fixes #423

merged 1 commit into from
Feb 19, 2019

Conversation

batsatt
Copy link
Contributor

@batsatt batsatt commented Feb 19, 2019

Fixes for unnecessary exception and DefaultLastHttpContent instantiation which were consuming ~ 5% on each request.

romain-grecourt
romain-grecourt approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@romain-grecourt romain-grecourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought of also changing readerFor to use imperative code to get rid of the use of streams, but that changes the scope of this PR.
LGTM

@batsatt batsatt assigned batsatt and unassigned spericas Feb 19, 2019
@batsatt batsatt requested a review from spericas February 19, 2019 21:48
@batsatt batsatt merged commit 26c04bf into helidon-io:master Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spericas spericas spericas approved these changes

@romain-grecourt romain-grecourt romain-grecourt approved these changes

Assignees

@batsatt batsatt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@batsatt @romain-grecourt @spericas