Fix deprecation annotations in metrics; update doc; revise examples (2.x) #4396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljnelson
previously approved these changes
Jun 15, 2022
ljnelson
previously approved these changes
Jun 15, 2022
tomas-langer
requested changes
Jun 16, 2022
metrics/metrics/src/main/java/io/helidon/metrics/MetricsSupportProviderImpl.java
Outdated
Show resolved
Hide resolved
ljamen
reviewed
Jun 16, 2022
tomas-langer
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4365
This PR:
@Deprecatedannotations as needed.docsto refer to the non-deprecated alternatives.Recall that metrics is now split into these components:
helidon-metrics-api- metrics-related interfaces (RegistryFactory,MetricsSettings, etc.) and a no-op implementationhelidon-metrics-service-api-MetricsSupportinterface and no-op implhelidon-metrics- full-featured metrics implIn the many places where examples used deprecated classes or methods this PR updates the code to use the non-deprecated alternatives.
Note that this involves changes to poms. Our doc tells users how to build and package metrics-capable apps which work regardless of whether the full metrics impl is present at runtime. This involves declaring build-time dependencies on
helidon-metrics-apiand/orhelidon-metrics-service-api(as needed) and then deciding if and how to make the full-featured impl available at runtime.I have changed the examples accordingly (I should have done this when I created the new components), including adding a runtime-scope dependency on the full-featured metrics impl. This way the examples serve as metrics-capable apps, and they also exhibit live metrics as they have before.