Some code cleanup and optimizations when writing data from Jersey #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om Jersey 2. Let Netty use the correct thread when reading and writing 3. Do not wait for a Netty write to complete before returning to Jersey. Signed-off-by: Santiago Pericas-Geertsen <Santiago.PericasGeertsen@oracle.com>
…heckstyle changes. Signed-off-by: Santiago Pericas-Geertsen <Santiago.PericasGeertsen@oracle.com>
barchetta
approved these changes
Feb 28, 2019
|
@barchetta Completed some manual testing with payloads over 5 MB without seeing any problems. Once the functional tests are in place, we should used those to further stress test these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details:
Although all tests are passing we should keep an eye for any regressions resulting from these changes.