-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Application subclasses available via our context during Feature executions #4745
Conversation
…is change makes the Application subclass available to the Feature during its execution. Just like for requests, the availability is through the Helidon context. Updated functional tests for multiple apps.
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
IIUC the developer's code (if it cares) needs to check which app the feature corresponds to. I see that the changes to the main (non-test) Helidon code now set the app subclass in the context but only the tests (i.e., the user code) retrieve it. Or put another way, there is no other Helidon code that directly uses features and therefore might need to look at the app subclass? |
Yes, a Feature is executed for each app for which it is part of.
Yes, this is mostly for user's logic. We already make it available during execution (e.g. in a request filter) and also as part of the Helidon context.
Right, I don't believe we use Features in Helidon (we use AutoDiscoverable from Jersey). This is mostly for app developers. |
…executions (#4745) * A global/shared Feature is executed for each Application subclass. This change makes the Application subclass available to the Feature during its execution. Just like for requests, the availability is through the Helidon context. Updated functional tests for multiple apps. * Small code improvement and fixed typo in copyright. * Handle case when Application subclass is not available via CDI. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
…executions (3.x) (#4786) * Make Application subclasses available via our context during Feature executions (#4745) * A global/shared Feature is executed for each Application subclass. This change makes the Application subclass available to the Feature during its execution. Just like for requests, the availability is through the Helidon context. Updated functional tests for multiple apps. * Small code improvement and fixed typo in copyright. * Handle case when Application subclass is not available via CDI. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> * Switched to jakarta packages. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
A global/shared Feature is executed for each Application subclass. This change makes the Application subclass available to the Feature during its execution. Just like for requests, the availability is through the Helidon context. Updated functional tests for multiple apps.