Skip to content

Provide configuration for enabled SSL protocols #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 16, 2019
Merged

Provide configuration for enabled SSL protocols #530

merged 6 commits into from
Apr 16, 2019

Conversation

romain-grecourt
Copy link
Contributor

@romain-grecourt romain-grecourt commented Mar 22, 2019 •
edited
Loading

Provide configuration for enabled SSL protocols.
Upgrade netty to 4.1.34
Fixes #519

@romain-grecourt
Fixes #519
32c24a8 
Provide configuration for enabled SSL protocols.
Upgrade netty to 4.1.34
@romain-grecourt romain-grecourt self-assigned this Mar 22, 2019
@romain-grecourt
Copy link
Contributor Author

@barchetta This requires PLS approval work for the netty version update.

@barchetta barchetta changed the title Fixes #519 WIP: Fixes #519 Mar 22, 2019
@barchetta barchetta changed the title WIP: Fixes #519 Fixes #519 Apr 10, 2019
barchetta
barchetta approved these changes Apr 10, 2019
View reviewed changes
Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for updating Netty version.

tomas-langer
tomas-langer reviewed Apr 11, 2019
View reviewed changes
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to have the new properties configurable using Config,
please have a look at SSLContextBuilder.java method public static SSLContext create(Config sslConfig) (I think)
That converts Config to SSL configuration.

@romain-grecourt romain-grecourt changed the title Fixes #519 Provide configuration for enabled SSL protocols Apr 12, 2019
@romain-grecourt

This comment has been minimized.

Sign in to view
@romain-grecourt romain-grecourt merged commit ab2da09 into master Apr 16, 2019
@romain-grecourt romain-grecourt deleted the helidon-519 branch April 16, 2019 01:11
@pejomstd pejomstd mentioned this pull request Apr 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-langer tomas-langer tomas-langer left review comments

@barchetta barchetta barchetta approved these changes

@spericas spericas Awaiting requested review from spericas

Assignees

@romain-grecourt romain-grecourt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NettyWebServer uses a deprecated constructor for JdkSslContext
3 participants
@romain-grecourt @barchetta @tomas-langer