Common context #600
Merged
Common context #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomas-langer
force-pushed
the
common-context
branch
2 times, most recently
from
d52e0e8 to
d3591ab
Compare
tomas-langer
force-pushed
the
common-context
branch
from
d3591ab to
7642814
Compare
batsatt
reviewed
May 2, 2019
common/context/src/main/java/io/helidon/common/context/Context.java
Outdated
Show resolved
Hide resolved
batsatt
reviewed
May 2, 2019
batsatt
reviewed
May 2, 2019
batsatt
reviewed
May 2, 2019
batsatt
reviewed
May 2, 2019
common/context/src/main/java/io/helidon/common/context/ContextAwareExecutorImpl.java
Outdated
Show resolved
Hide resolved
batsatt
reviewed
May 2, 2019
common/context/src/main/java/io/helidon/common/context/ContextAwareExecutorImpl.java
Outdated
Show resolved
Hide resolved
batsatt
reviewed
May 2, 2019
batsatt
reviewed
May 2, 2019
common/context/src/test/java/io/helidon/common/context/ContextAwareScheduledExecutorTest.java
Show resolved
Hide resolved
batsatt
reviewed
May 2, 2019
common/context/src/test/java/io/helidon/common/context/ContextAwareScheduledExecutorTest.java
Show resolved
Hide resolved
batsatt
reviewed
May 2, 2019
common/context/src/test/java/io/helidon/common/context/ContextAwareScheduledExecutorTest.java
Show resolved
Hide resolved
batsatt
reviewed
May 2, 2019
common/context/src/test/java/io/helidon/common/context/ContextAwareScheduledExecutorTest.java
Show resolved
Hide resolved
batsatt
reviewed
May 2, 2019
common/http/src/main/java/io/helidon/common/http/ContextualRegistry.java
Show resolved
Hide resolved
|
Resolves #596 |
|
Added context id. Also the existing |
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
common context. Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
tomas-langer
force-pushed
the
common-context
branch
from
0d1d4bc to
229ec69
Compare
aseovic
reviewed
May 6, 2019
common/context/src/main/java/io/helidon/common/context/Contexts.java
Outdated
Show resolved
Hide resolved
aseovic
reviewed
May 6, 2019
common/context/src/main/java/io/helidon/common/context/ContextAwareExecutorImpl.java
Show resolved
Hide resolved
aseovic
previously approved these changes
May 6, 2019
There was a problem hiding this comment.
In general, this all looks good to me and I only had a few minor comments.
One thing that concerns me a bit is that this is all very similar to how gRPC Context works, but we probably won't be able to use it as a direct replacement, as gRPC internally uses and expects its own implementation. Will need to take a deeper look into it, and see if it's possible to adapt one context implementation to another.
spericas
previously approved these changes
May 6, 2019
batsatt
reviewed
May 6, 2019
common/context/src/main/java/io/helidon/common/context/Contexts.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
batsatt
previously approved these changes
May 7, 2019
spericas
previously approved these changes
May 7, 2019
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
spericas
approved these changes
May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First implementation of the common context described in #599