Skip to content

Add Implementation headers to jar MANIFEST #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 24, 2019
Merged

Add Implementation headers to jar MANIFEST #618

merged 3 commits into from
Apr 24, 2019

Conversation

barchetta
Copy link
Member

@barchetta barchetta commented Apr 23, 2019 •
edited
Loading

Fixes #617

With this fix you get:

$ unzip -p $HOME/.m2/repository/io/helidon/webserver/helidon-webserver/1.0.4-SNAPSHOT/helidon-webserver-1.0.4-SNAPSHOT.jar META-INF/MANIFEST.MF
Manifest-Version: 1.0
Implementation-Title: Helidon WebServer
Implementation-Version: 1.0.4-SNAPSHOT
Built-By: jdipol
Implementation-Vendor-Id: io.helidon.webserver
Created-By: Apache Maven 3.5.4
Build-Jdk: 1.8.0_162
Implementation-URL: https://helidon.io
Implementation-Vendor: Oracle Corporation
Scm-Revision: 03e3f264daa0a266bdb5fc09db5fe4359b95df73

@barchetta barchetta self-assigned this Apr 23, 2019
romain-grecourt
romain-grecourt reviewed Apr 23, 2019
View reviewed changes
Copy link
Contributor

@romain-grecourt romain-grecourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should perhaps also update the version class with the SCM revision info.

@barchetta
Copy link
Member Author

Added revision to Version class.

@barchetta barchetta merged commit ff8dd9d into helidon-io:master Apr 24, 2019
@barchetta barchetta deleted the 617-manifest-headers branch May 20, 2019 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romain-grecourt romain-grecourt romain-grecourt approved these changes

Assignees

@barchetta barchetta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jar files don't contain Implementation-* headers
2 participants
@barchetta @romain-grecourt