Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ThreadPool injection into Application. #713

Merged
merged 1 commit into from
May 20, 2019
Merged

Enable ThreadPool injection into Application. #713

merged 1 commit into from
May 20, 2019

Conversation

batsatt
Copy link
Contributor

@batsatt batsatt commented May 20, 2019

The previous implementation worked for all JAX-RS supported types except Application, as it configured the injection after the application was initialized.

@batsatt batsatt self-assigned this May 20, 2019
@batsatt batsatt added the MP label May 20, 2019
@batsatt batsatt requested a review from spericas May 20, 2019 17:50
spericas
spericas approved these changes May 20, 2019
View reviewed changes
Copy link
Member

@spericas spericas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@batsatt batsatt merged commit 7db7b32 into helidon-io:master May 20, 2019
@batsatt batsatt deleted the thread-pool-injection branch May 20, 2019 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spericas spericas spericas approved these changes

Assignees

@batsatt batsatt

Labels
MP
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@batsatt @spericas