Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed backwards use of isAssignableFrom() and created new unit test #731

Merged
merged 1 commit into from
May 23, 2019
Merged

Fixed backwards use of isAssignableFrom() and created new unit test #731

merged 1 commit into from
May 23, 2019

Conversation

spericas
Copy link
Member

Signed-off-by: Santiago Pericas-Geertsen Santiago.PericasGeertsen@oracle.com

@spericas
Fixed backwards use of isAssignableFrom() and created new unit test.
76ab91e 
Signed-off-by: Santiago Pericas-Geertsen <Santiago.PericasGeertsen@oracle.com>
@spericas spericas added the bug Something isn't working label May 22, 2019
@spericas spericas requested a review from ljnelson May 22, 2019 20:14
@spericas spericas self-assigned this May 22, 2019
ljnelson
ljnelson approved these changes May 22, 2019
View reviewed changes
Copy link
Member

@ljnelson ljnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ljnelson ljnelson merged commit 3f9a150 into helidon-io:master May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljnelson ljnelson ljnelson approved these changes

Assignees

@spericas spericas

Labels
bug Something isn't working
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spericas @ljnelson