Fixes support for application calls to flush() when using StreamingOutput #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tput. Signed-off-by: Santiago Pericas-Geertsen <Santiago.PericasGeertsen@oracle.com>
spericas
changed the title
ljnelson
reviewed
Jun 11, 2019
| out.write(("{ value: \"first\" }\n").getBytes(StandardCharsets.UTF_8)); | ||
| out.flush(); | ||
|
|
||
| Thread.sleep(2000); // wait before sending next chunk |
There was a problem hiding this comment.
Minor nit: I know what you're doing here, but it will slow down the CI/CD builds.
There was a problem hiding this comment.
I'll reduce the wait time, I don't think it needs to be that long.
ljnelson
previously approved these changes
Jun 11, 2019
Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
ljnelson
approved these changes
Jun 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes support for application calls to flush() when using StreamingOutput.
Signed-off-by: Santiago Pericas-Geertsen Santiago.PericasGeertsen@oracle.com