Create helidon context in gRPC server implementation #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomas-langer
requested changes
Jun 10, 2019
grpc/server/src/main/java/io/helidon/grpc/server/GrpcServer.java
Outdated
Show resolved
Hide resolved
grpc/server/src/main/java/io/helidon/grpc/server/GrpcServerImpl.java
Outdated
Show resolved
Hide resolved
grpc/server/src/main/java/io/helidon/grpc/server/GrpcServerImpl.java
Outdated
Show resolved
Hide resolved
tomas-langer
requested changes
Jun 11, 2019
grpc/server/src/main/java/io/helidon/grpc/server/GrpcServerImpl.java
Outdated
Show resolved
Hide resolved
…ntext as a parent
|
I don't have permissions to merge; someone else will need to do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is for issue #698.
This change adds a ability to set a Helidon
io.helidon.common.context.Contextwhen creating the gRPC server by calling thecontext(Context context)method on theGrpcServerConfiguration.Builderwhen creating the server configuration that will be used to configure the gRPC server.The Thread factory used by the gRPC server thread pool creates threads that have the context set so that the context can be obtained using the static
io.helidon.common.context.Contexts.context()method in call handling code. The context can also be obtained from the gRPC call context inside a gRPC service method using theio.helidon.grpc.core.ContextKeys.HELIDON_CONTEXT.get()method.If tracing is enabled, the
Tracerand the currentSpanContextare set into theContextat the start of a gRPC server call so that they are available during handling of the call.If security is enabled then the
SecurityContextis also set into theContext.