Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload File command should show an error if upload fails #503

Open
michoelchaikin opened this issue Jan 12, 2022 · 1 comment
Open

Upload File command should show an error if upload fails #503

michoelchaikin opened this issue Jan 12, 2022 · 1 comment
Labels
enhancement New feature or request SuiteCloud Extension for VSCode Bugs related to the suitecloud extension for visual studio code tracked Already in Backlog

Comments

@michoelchaikin
Copy link

Your environment

SuiteCloud Extension for Visual Studio Code v1.0.3

Describe the bug

If the Upload File command fails (for example due to a syntax error in the file), the VS Code extension still displays the message, "'Upload File' has been successfully executed").

To Reproduce

Create a suitescript file with a syntax error, and then try run the command SuiteCloud: Upload File

Actual Behavior

The file fails to upload, however, this is not reflected in the message.

image

Expected Behavior

It's expected that if the file upload failed, an error message should be shown instead to inform the user of such.

@michoelchaikin michoelchaikin added the bug Something isn't working label Jan 12, 2022
@alisyed-19 alisyed-19 added enhancement New feature or request SuiteCloud Extension for VSCode Bugs related to the suitecloud extension for visual studio code and removed bug Something isn't working labels Mar 16, 2022
@alisyed-19
Copy link
Member

This is not a bug. The pop-up just informs that the command execution has finished successfully. See details for more information.
But I understand this can be misleading. We will see if this can be enhanced.

@tourajvaziri tourajvaziri added the tracked Already in Backlog label Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request SuiteCloud Extension for VSCode Bugs related to the suitecloud extension for visual studio code tracked Already in Backlog
Projects
None yet
Development

No branches or pull requests

3 participants