Fixed bug that prevented cursors from implicit results sets from being

closed.

Author: anthony-tuininga

doc/src/release_notes.rst

@@ -23,6 +23,8 @@ Thin Mode Changes
 #)  Fixed bug with re-execution of SQL that requires a define, such as occurs
     when setting `oracledb.defaults.fetch_lobs` to the value `False`
     (`issue 41 <https://github.com/oracle/python-oracledb/issues/41>`__).
+#)  Fixed bug that prevented cursors from implicit results sets from being
+    closed.
 
 Common Changes
 ++++++++++++++

src/oracledb/base_impl.pxd

@@ -251,7 +251,6 @@ cdef class BaseCursorImpl:
         uint32_t _buffer_index
         uint32_t _fetch_array_size
         bint _more_rows_to_fetch
-        bint _is_implicit_cursor
 
     cdef int _bind_values(self, object cursor, object type_handler,
                           object params, uint32_t num_rows, uint32_t row_num,

src/oracledb/impl/thick/cursor.pyx

@@ -33,6 +33,7 @@
 cdef class ThickCursorImpl(BaseCursorImpl):
     cdef:
         ThickConnImpl _conn_impl
+        bint _is_implicit_cursor
         bint _fixup_ref_cursor
         dpiStmtInfo _stmt_info
         dpiStmt *_handle

src/oracledb/impl/thin/cursor.pyx

@@ -46,8 +46,7 @@ cdef class ThinCursorImpl(BaseCursorImpl):
 
     cdef int _close(self, bint in_del) except -1:
         if self._statement is not None:
-            if not self._is_implicit_cursor:
-                self._conn_impl._return_statement(self._statement)
+            self._conn_impl._return_statement(self._statement)
             self._statement = None
 
     cdef BaseVarImpl _create_var_impl(self, object conn):
@@ -188,8 +187,7 @@ cdef class ThinCursorImpl(BaseCursorImpl):
     def prepare(self, str sql, str tag, bint cache_statement):
         self.statement = sql
         if self._statement is not None:
-            if not self._is_implicit_cursor:
-                self._conn_impl._return_statement(self._statement)
+            self._conn_impl._return_statement(self._statement)
             self._statement = None
         self._statement = self._conn_impl._get_statement(sql.strip(),
                                                          cache_statement)

src/oracledb/impl/thin/messages.pyx

@@ -747,7 +747,6 @@ cdef class MessageWithData(Message):
             child_cursor = self._create_cursor_from_describe(buf)
             child_cursor_impl = child_cursor._impl
             buf.read_ub2(&child_cursor_impl._statement._cursor_id)
-            child_cursor_impl._is_implicit_cursor = True
             self.cursor_impl._implicit_resultsets.append(child_cursor)
 
     cdef int _process_io_vector(self, ReadBuffer buf) except -1: