Skip to content

Commit c73ba53

Browse files
Fixed a bug resultging in a segfault when attempting to use an output
type handler while fetching data frames (#486).
1 parent f782233 commit c73ba53

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

doc/src/release_notes.rst

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,11 @@ Thick Mode Changes
2727
Common Changes
2828
++++++++++++++
2929

30+
#) Fixed a bug resulting in a segfault when attempting to use an
31+
:ref:`output type handler <outputtypehandlers>` while fetching data frames
32+
with :meth:`Connection.fetch_df_all()` and
33+
:meth:`Connection.fetch_df_batches()`
34+
(`issue 486 <https://github.com/oracle/python-oracledb/issues/486>`__).
3035
#) Added support for using the Cython 3.1 release
3136
(`issue 493 <https://github.com/oracle/python-oracledb/issues/493>`__).
3237
#) Miscellaneous grammar and spelling fixes by John Bampton

src/oracledb/impl/base/cursor.pyx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -301,11 +301,15 @@ cdef class BaseCursorImpl:
301301
"""
302302
Return the output type handler to use for the cursor. If one is not
303303
directly defined on the cursor then the one defined on the connection
304-
is used instead.
304+
is used instead. When fetching Arrow data, however, no output type
305+
handlers are used since for most data no conversion to Python objects
306+
ever takes place.
305307
"""
306308
cdef:
307309
BaseConnImpl conn_impl
308310
object type_handler
311+
if self.fetching_arrow:
312+
return None
309313
if self.outputtypehandler is not None:
310314
type_handler = self.outputtypehandler
311315
else:

0 commit comments

Comments
 (0)