Added unit tests.

Author: ankedia

operator/src/test/java/oracle/kubernetes/operator/JobWatcherTest.java

@@ -4,6 +4,8 @@
 package oracle.kubernetes.operator;
 
 import java.math.BigInteger;
+import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.Collections;
 import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.function.Function;
@@ -128,6 +130,28 @@ public void whenJobConditionStatusFalse_reportNotComplete() {
     assertThat(JobWatcher.isComplete(cachedJob), is(false));
   }
 
+  @Test
+  public void whenJobConditionTypeFailedWithTrueStatus_reportFailed() {
+    cachedJob.status(new V1JobStatus().addConditionsItem(new V1JobCondition().type("Failed").status("True")));
+
+    assertThat(JobWatcher.isFailed(cachedJob), is(true));
+  }
+
+  @Test
+  public void whenJobConditionTypeFailedWithNoStatus_reportNotFailed() {
+    cachedJob.status(new V1JobStatus().addConditionsItem(new V1JobCondition().type("Failed").status("")));
+
+    assertThat(JobWatcher.isFailed(cachedJob), is(false));
+  }
+
+  @Test
+  public void whenJobHasStatusWithNoConditionsAndNotFailed_reportNotFailed() {
+    cachedJob.status(new V1JobStatus().conditions(Collections.emptyList()));
+
+    assertThat(JobWatcher.isFailed(cachedJob), is(false));
+  }
+
+
   @Test
   public void whenJobRunningAndReadyConditionIsTrue_reportComplete() {
     markJobCompleted(cachedJob);
@@ -151,6 +175,10 @@ private V1Job markJobFailed(V1Job job) {
     return setFailedWithReason(job, null);
   }
 
+  private V1Job markJobConditionFailed(V1Job job) {
+    return setFailedConditionWithReason(job, null);
+  }
+
   private V1Job markJobTimedOut(V1Job job) {
     return markJobTimedOut(job, "DeadlineExceeded");
   }
@@ -163,11 +191,22 @@ private V1Job setFailedWithReason(V1Job job, String reason) {
     return job.status(new V1JobStatus().failed(1).addConditionsItem(createCondition("Failed").reason(reason)));
   }
 
+  private V1Job setFailedConditionWithReason(V1Job job, String reason) {
+    return job.status(new V1JobStatus().conditions(
+            new ArrayList<>(Arrays.asList(new V1JobCondition().type("Failed").status("True").reason(reason)))));
+  }
+
   @Test
   public void whenJobHasNoStatus_reportNotFailed() {
     assertThat(JobWatcher.isFailed(cachedJob), is(false));
   }
 
+  @Test
+  public void whenJobHasNoStatusAndFailedCondition_reportFailed() {
+    markJobFailed(cachedJob);
+    assertThat(JobWatcher.isFailed(cachedJob), is(true));
+  }
+
   @Test
   public void whenJobHasFailedCount_reportFailed() {
     cachedJob.status(new V1JobStatus().failed(1));
@@ -248,6 +287,13 @@ public void whenWaitForReadyAppliedToFailedJob_performNextStep() {
     assertThat(terminalStep.wasRun(), is(true));
   }
 
+  @Test
+  public void whenWaitForReadyAppliedToJobWithFailedCondition_performNextStep() {
+    startWaitForReady(this::markJobConditionFailed);
+
+    assertThat(terminalStep.wasRun(), is(true));
+  }
+
   // Starts the waitForReady step with job modified as needed
   private void startWaitForReady(Function<V1Job,V1Job> jobFunction) {
     AtomicBoolean stopping = new AtomicBoolean(false);