Search method returns undefined elements

[mateonunez]

Describe the bug
Searching by a term that doesn't exist, Lyra returns X undefined elements.

The error also occurs using limit, property or exact params.

To Reproduce
Steps to reproduce the behavior:

1. lyra.search({ term: "whatever" })

Expected behavior
Lyra shouldn't return X undefined elements. Instead of that should return an empty array.

Screenshots

Desktop:

• OS: Windows 11
• Environment: Node
• Node: v18.6.0
• pnpm: v7.5.1
• Lyra: v0.0.1-beta-12

[micheleriva]

When retrieving data, we create an array of x length, where x is the limit search param. That way we avoid unnecessary dynamic allocations when adding data to the results array, but of course is causing this problem

const results: RetrievedDoc<TSchema>[] = Array.from({
  length: limit,
});

Thanks for opening the issue!

[mateonunez]

And what would be the correct way to fix it?
Create an Array that also allows dynamic allocations (in my opinion could be fixed in this way)? Or filter the Array before the return?

[micheleriva]

I'd say... let's benchmark these operations with different array sizes. Let's see when is convenient filtering vs dynamic arrays given the docs we have