Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vitepress-Plugin] When clicking on the search result it gives error 404 #604

Closed
Heus-Sueh opened this issue Jan 10, 2024 · 1 comment · Fixed by #685
Closed

[Vitepress-Plugin] When clicking on the search result it gives error 404 #604

Heus-Sueh opened this issue Jan 10, 2024 · 1 comment · Fixed by #685

Comments

@Heus-Sueh
Copy link

Describe the bug

Screencast.from.2024-01-10.19-42-26.webm

The expected result was for him to send it to this link:

image

Right URL:
Megathread-V2/pages/jogos.html#🔗-elamigos

Wrong URL:
/pages/jogos.html#elamigosogos.html#elamigos

Orama takes me to the wrong url, and it seems, it doesn't get the entire heading, it ignores the emoji completely and it doesn't respect the base setting that defines the base url

my base is defined as: "/Megathread-v2/"

To Reproduce

define a base in vitepress and put some emoji in the heading along with a space

Expected behavior

When I click on the result it takes me to the right url

Right URL:
Megathread-V2/pages/jogos.html#🔗-elamigos

Environment Info

OS: Linux
Node: v21.5.0
@orama/plugin-vitepress: 2.0.0-beta.12

Affected areas

Search

Additional context

No response

@micheleriva
Copy link
Member

we see the error, let us reproduce and fix this. Thanks for opening this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants