Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigInt support #9

Open
airhorns opened this issue Dec 7, 2024 · 3 comments
Open

BigInt support #9

airhorns opened this issue Dec 7, 2024 · 3 comments

Comments

@airhorns
Copy link

airhorns commented Dec 7, 2024

It'd be great to be able to serialize bigints into the sequence with a BigInt64Array or similar under the hood. I can contribute support for this if you like -- any specifics that are important for getting this right?

@allevo
Copy link
Collaborator

allevo commented Dec 9, 2024

Hi!
Thanks for your interest in this project.
We haven't implemented the bigint support, but we accept PR!

So, we don't have any specification restrictions; just don't be slower if the developer doesn't use bitint at all. I'll gladly discuss the specifications before the PR to speed up the merge and the release.

@airhorns
Copy link
Author

airhorns commented Dec 9, 2024

What do you think the best way to do it is? Should it be another parallel array buffer? Or re-use one of the existing ones?

@allevo
Copy link
Collaborator

allevo commented Dec 9, 2024

DataView creation could be problematic because it introduces a performance penalty during creation.
The best approach is to leverage the existing views. But I don't know if it is doable or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants