Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try replacing Storybook #1186

Open
orange-buffalo opened this issue Apr 7, 2024 · 1 comment
Open

Try replacing Storybook #1186

orange-buffalo opened this issue Apr 7, 2024 · 1 comment

Comments

@orange-buffalo
Copy link
Owner

What we have

We use Storybook for executing screenshot tests, mostly for components in various states but also for some pages (which we will remove some time in the future). We do not need any other feature of Storybook.

However, Storybook maintenance cost is very high. They constantly break the APIs and require complex migrations, they bring dirty dependencies into the project.

Goals

Get rid of Storybook, preserving screenshot tests for components:

  1. We do not need fancy navigation. In the worst case, a single "contents" page with links to all "stories" would be sufficient.
  2. Potentially, we can use https://vitejs.dev/guide/build.html#multi-page-app support. However, it is not clear if the build output can be clear in this case, as we do not want to bring this tests compiled frontend into Production code.
  3. We then can replace obscure infrastructure waitFor* helpers with standard Playwright lookups/assertions.
@orange-buffalo orange-buffalo moved this from New to Todo in simple-accounting Apr 7, 2024
@orange-buffalo orange-buffalo moved this from Todo to In Progress in simple-accounting Apr 13, 2024
@orange-buffalo
Copy link
Owner Author

https://histoire.dev/guide/vue3/stories.html looks very promising (native Vue and Vite support), but Bun does not support it yet: oven-sh/bun#3787

@orange-buffalo orange-buffalo moved this from In Progress to Todo in simple-accounting Apr 13, 2024
@orange-buffalo orange-buffalo moved this from Todo to Backlog in simple-accounting Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

1 participant