Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider changing to string IDs #950

Open
orange-buffalo opened this issue Sep 30, 2023 · 0 comments
Open

Consider changing to string IDs #950

orange-buffalo opened this issue Sep 30, 2023 · 0 comments
Labels
tech-debt

Comments

@orange-buffalo
Copy link
Owner

We faced an issue during the tests, when we initialized IDs with Long.MIN_VALUE but it was out of Javascript Number range, so overflow caused broken IDs. See Prototypes.

We should, at least on API level, expose IDs as strings. Probably for consistency it makes sense to have then as strings in database as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech-debt
Projects
simple-accounting
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@orange-buffalo