Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vcda_ip resource #13

Merged
merged 2 commits into from
Feb 10, 2023
Merged

feat: add vcda_ip resource #13

merged 2 commits into from
Feb 10, 2023

Conversation

gaetanars
Copy link
Contributor

Description of your changes

Add cloudavenue_vcda_resource

If you submit change in the provider code, please make sure to:

  • Write or modify examples in examples/ directory
  • Write or modify acceptance tests
  • Run make generate to ensure the doc was updated properly

How has this code been tested

@crown-app crown-app bot added Feature size/L Large PR labels Feb 7, 2023
@gaetanars gaetanars force-pushed the vcda_resource branch 5 times, most recently from a2a41e7 to 5087969 Compare February 9, 2023 07:46
@gaetanars gaetanars marked this pull request as ready for review February 10, 2023 09:36
@gaetanars gaetanars requested a review from azrod February 10, 2023 09:36
Copy link
Member

@azrod azrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Timeouts on Create and Delete

@gaetanars
Copy link
Contributor Author

/label:add category/vcda

@gaetanars gaetanars merged commit 49e304f into main Feb 10, 2023
@gaetanars gaetanars deleted the vcda_resource branch February 10, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Large PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants