Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer friend field naming for x-osb-cmdb #100

Open
gberche-orange opened this issue Mar 3, 2021 · 0 comments
Open

Developer friend field naming for x-osb-cmdb #100

gberche-orange opened this issue Mar 3, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@gberche-orange
Copy link
Member

gberche-orange commented Mar 3, 2021

Expected behavior

As a service broker author

Observed behavior

x-osb-cmdb uses dash character which is not supported in field name in

Use of _ would be more developer friendly.

Affected release

Reproduced on version 1.4.0

Alternative fixes

  1. introduce a new field x_osb_cmdb. Document x-osb-cmdb as deprecated but keep it.
  2. introduce a new field x_osb_cmdb. Remove x-osb-cmdb field from requests (breaking change)
  3. introduce a new field x_osb_cmdb. add opt-in to keep x-osb-cmdb (likely as user-facing a catalog tag/metadata)

Impacts of 1) :

  • more verbose payload
  • confusions for service broker authors to see duplicated fields

Impacts of 2) :

  • service brokers with existing updateable service instances need to support both variations x_osb_cmdb and x-osb-cmdb (since once the breaking change is deployed they will receive updates including x_osb_cmdb param

Impacts of 3)

  • user-facing opt-in somewhat damages UX
  • implementation complexity for osb-cmdb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant