Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legacy docker config is not supported #1143

Closed
1 task
qweeah opened this issue Oct 12, 2023 · 1 comment
Closed
1 task

legacy docker config is not supported #1143

qweeah opened this issue Oct 12, 2023 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@qweeah
Copy link
Contributor

qweeah commented Oct 12, 2023

What happened in your environment?

Suppose we have below configuration in the registry config file:

{
  ...
  "auths": {
    "https://my.registry.io/": {
      "auth": "************",
      "email": ""
    }
  }
  ...
}

ORAS commands won't pick up the stored auth credentials when interacting with registry my.registry.io

What did you expect to happen?

If this legacy format is not deprecated, ORAS should use the credentials in the docker config with legacy format.

How can we reproduce it?

  1. Change the stored credentials into legacy format: Found an entry of your registry config file, add prefix https:// to the registry key name to the entry.
  2. Use ORAS commands against the modified registry, if authentication is required, the command will end with 401.

What is the version of your ORAS CLI?

v1.1.0

What is your OS environment?

Ubuntu 20.04

Are you willing to submit PRs to fix it?

  • Yes, I am willing to fix it.
@qweeah
Copy link
Contributor Author

qweeah commented Nov 23, 2023

Fixed by #1154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants