Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ORAS debug log should scrub Set-Cookie header in the logs #1189

Closed
1 task done
qweeah opened this issue Nov 23, 2023 · 0 comments · Fixed by #1190
Closed
1 task done

ORAS debug log should scrub Set-Cookie header in the logs #1189

qweeah opened this issue Nov 23, 2023 · 0 comments · Fixed by #1190
Assignees
@qweeah
Labels
enhancement New feature or request
Milestone
v1.2.0-rc.1

Comments

@qweeah
Copy link
Contributor

qweeah commented Nov 23, 2023

What is the version of your ORAS CLI

1.1.0

What would you like to be added?

The Set-Cookie header might contains sensitive information and need to be scrubbed from the debug logs.

Why is this needed for ORAS?

So user won't need to redact the header when pasting the ORAS logs online.

Are you willing to submit PRs to contribute to this feature?

  • Yes, I am willing to implement it.
@qweeah qweeah added enhancement New feature or request triage New issues or PRs to be acknowledged by maintainers labels Nov 23, 2023
@qweeah qweeah added this to the v1.2.0 milestone Nov 23, 2023
@qweeah qweeah self-assigned this Nov 23, 2023
@qweeah qweeah mentioned this issue Nov 23, 2023
Merged
@yizha1 yizha1 removed the triage New issues or PRs to be acknowledged by maintainers label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qweeah qweeah

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.2.0-rc.1
Development

Successfully merging a pull request may close this issue.

feat: scrub Set-Cookie header in debug logs qweeah/oras
2 participants
@qweeah @yizha1