Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor CLI main package #824

Closed
qweeah opened this issue Feb 20, 2023 · 2 comments
Closed

refactor CLI main package #824

qweeah opened this issue Feb 20, 2023 · 2 comments
Assignees
@qweeah
Milestone
v1.1.0

Comments

@qweeah
Copy link
Contributor

qweeah commented Feb 20, 2023 •
edited
Loading

Currently both the root command and some sub-commands are implemented in the main package, which is not a good practice for Cobra.

Also to satisfy #807, all the command types should be moved out of the main package with root command type exported publicly.
@qweeah qweeah self-assigned this Feb 20, 2023
This was referenced Feb 20, 2023
Closed
Merged
@qweeah
Copy link
Contributor Author

qweeah commented Feb 20, 2023

Also command execution should be based on the same context passed from the root Cobra command.

@qweeah qweeah mentioned this issue Mar 12, 2023
Merged
4 tasks
@shizhMSFT shizhMSFT added this to the future milestone Mar 22, 2023
@qweeah qweeah mentioned this issue Mar 23, 2023
Merged
4 tasks
@qweeah qweeah modified the milestones: future, v1.1.0 Jul 6, 2023
@qweeah
Copy link
Contributor Author

qweeah commented Jul 10, 2023

Closing as it is already completed in #899.

@qweeah qweeah closed this as completed Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qweeah qweeah

Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
2 participants
@qweeah @shizhMSFT