Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

end-to-end test generated coverage profile #900

Closed
1 task done
qweeah opened this issue Mar 23, 2023 · 0 comments · Fixed by #903
Closed
1 task done

end-to-end test generated coverage profile #900

qweeah opened this issue Mar 23, 2023 · 0 comments · Fixed by #903
Labels
E2E testing End-to-end testing related issues or pull requests enhancement New feature or request
Milestone

Comments

@qweeah
Copy link
Contributor

qweeah commented Mar 23, 2023

What is the version of your ORAS CLI

1.0.0

What would you like to be added?

Run end-to-end tests based on instrumented application and generate coverage report accordingly.

The released application will still not be instrumented.

Why is this needed for ORAS?

Currently oras' code coverage statistics are generated by unit testing, which is not accurate since:

  1. By design, unit tests coverage report will only include files within the package. E.g if package a uses package b and a have unit test specs in a_test.go, unit test coverage report will not include package b.
  2. If a package is not included, Codecov report will skip the line counting, which means some uncovered code may be silently ignored. E.g. oras.land/oras/cmd/oras/... are not covered and not calculated in oras 0.16. There are approximately 2K lines of golang code in oras but Codecov only show coverage for 550+ lines.
  3. Code coverage of end-to-end tests are not counted.

Are you willing to submit PRs to contribute to this feature?

  • Yes, I am willing to implement it.
@qweeah qweeah added enhancement New feature or request E2E testing End-to-end testing related issues or pull requests labels Mar 23, 2023
@qweeah qweeah added this to the v1.1.0 milestone Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E2E testing End-to-end testing related issues or pull requests enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant