Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve path traversal error msg of oras pull #978

Closed
qweeah opened this issue Jun 19, 2023 · 3 comments
Closed

improve path traversal error msg of oras pull #978

qweeah opened this issue Jun 19, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@qweeah
Copy link
Contributor

qweeah commented Jun 19, 2023

If path of artifact blobs are absolute and needs to be pulled outside of current working directory, by default oras pull will be terminated with error like path traversal disallowed

Need to advise user action for this specific error, like Use pull with option -T/allow-path-traversal to allow path traversal

Can this be added to the error message when the pull fails with "Path travel disallowed". Use pull with option -T or --allow-path-traversal to allow path traversal.

Originally posted by @suganyas in #973 (comment)

@qweeah
Copy link
Contributor Author

qweeah commented Jun 27, 2023

@suganyas Can you help fix this issue?

@suganyas
Copy link
Contributor

@qweeah I am working on this as part of PR #988

@shizhMSFT shizhMSFT added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Jun 28, 2023
@shizhMSFT shizhMSFT added this to the v1.1.0 milestone Jun 28, 2023
@qweeah qweeah closed this as completed Jun 29, 2023
@qweeah
Copy link
Contributor Author

qweeah commented Jun 29, 2023

completed in #988

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

3 participants