Stricter types

Author: julienmalard

src/nested.ts

@@ -101,7 +101,7 @@ export const NestedApi = ({ database }: { database: InternalDatabase }) => {
     return addOperation({ op: "DEL", key: joinedKey, value: null });
   };
 
-  const get = async (key: NestedKey): Promise<PossiblyNestedValue> => {
+  const get = async (key: NestedKey): Promise<PossiblyNestedValue | undefined> => {
     const joinedKey = typeof key === "string" ? key : joinKey(key);
     const relevantKeyValues: { key: string; value: DagCborEncodable }[] = [];
 
@@ -131,7 +131,7 @@ export const NestedApi = ({ database }: { database: InternalDatabase }) => {
   ): Promise<string[]> => {
     let flattenedEntries: { key: string; value: DagCborEncodable }[];
     if (typeof keyOrObject === "string") {
-      flattenedEntries = flatten(object).map((entry) => ({
+      flattenedEntries = flatten(object!).map((entry) => ({
         key: `${keyOrObject}/${entry.key}`,
         value: entry.value,
       }));
@@ -159,15 +159,18 @@ export const NestedApi = ({ database }: { database: InternalDatabase }) => {
     };
     for await (const entry of log.traverse()) {
       const { op, key, value } = entry.payload;
+      if (typeof key !== "string") continue;
+
       if (op === "PUT" && !keyExists(key)) {
+        if (value === undefined) continue;
         keys[key] = true;
         count++;
         const hash = entry.hash;
         yield { key, value, hash };
       } else if (op === "DEL" && !keyExists(key)) {
         keys[key] = true;
       }
-      if (count >= amount) {
+      if (amount !== undefined && count >= amount) {
         break;
       }
     }

src/utils.ts

@@ -31,7 +31,7 @@ export const flatten = (
     x: PossiblyNestedValue,
     rootKey: string[],
   ): void => {
-    if (typeof x === "object" && !Array.isArray(x)) {
+    if (typeof x === "object" && !Array.isArray(x) && x !== null) {
       for (const [key, value] of Object.entries(x)) {
         recursiveFlatten(value, [...rootKey, key]);
       }
@@ -55,7 +55,8 @@ export const toNested = (
       if (typeof root[c] !== "object" || Array.isArray(root[c])) root[c] = {};
       root = root[c] as NestedValue;
     }
-    root[keyComponents.pop()] = value;
+    const finalKeyComponent = keyComponents.pop()
+    if (finalKeyComponent) root[finalKeyComponent] = value;
   }
   return nested;
 };

tsconfig.json

@@ -12,16 +12,16 @@
     "moduleResolution": "node",
     "noFallthroughCasesInSwitch": true,
     "noImplicitReturns": true,
-    "noUnusedLocals": false,
-    "noUnusedParameters": false,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true,
     "paths": {
       "@/*": ["src/*"]
     },
     "outDir": "./dist",
     "sourceMap": true,
     "strict": true,
-    "strictPropertyInitialization": false,
-    "strictNullChecks": false,
+    "strictPropertyInitialization": true,
+    "strictNullChecks": true,
     "target": "esnext",
     "useUnknownInCatchVariables": false,