Run tests with ipfs-api and go-ipfs again #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haadcode
force-pushed
the
fix/ipfs-api
branch
5 times, most recently
from
40cac01 to
01ce3da
Compare
|
👏🏽👏🏽👏🏽👏🏽👏🏽 |
test/docstore.test.js
Outdated
| afterEach(async () => { | ||
| await db.drop() | ||
| it('creates and opens a database', async () => { | ||
| db = await orbitdb1.docstore('first doc database') |
There was a problem hiding this comment.
Good catch and it seems to be a problem with all stores. They also don't seem to contain an assert for that test.
|
I'm going to split this PR in two, because there's really two major things in it atm:
The first part is to just update the tests to use ipfsd-ctl and the second part brings in everything we need to run with go-ipfs again. |
|
Closes #273 |
|
Using ipfsd-ctl to run the tests is now a separate PR here #335 |
haadcode
changed the title
haadcode
force-pushed
the
fix/ipfs-api
branch
3 times, most recently
from
2a60020 to
6bb284d
Compare
haadcode
changed the title
haadcode
force-pushed
the
fix/ipfs-api
branch
3 times, most recently
from
140880b to
f2c5d04
Compare
Use go-ipfs 0.4.13 to run tests Add write benchmark for go-ipfs Clean up benchmarks Fix a test not catching errors
|
This was now finally finished and in itself became a rather small PR compared to the original. The main work was done in the previous PRs (see commit log). Going to merge this to master and keep testing it for some time before making a new release (0.20.0). We now support go-ipfs again! 🎉 🚀 😄 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to make OrbitDB run tests with go-ipfs again (through js-ipfs-api) in addition to running them with js-ipfs.
This PR will: