Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline comments processing is wrong with tables #103

Closed
orchestr7 opened this issue Feb 11, 2022 · 0 comments · Fixed by #113
Closed

Inline comments processing is wrong with tables #103

orchestr7 opened this issue Feb 11, 2022 · 0 comments · Fixed by #113
Assignees
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed refactoring

Comments

@orchestr7
Copy link
Owner

[fruits] # comment
     name = "apple"

[[array]] # comment
     name = "apple" 

These comments will be parsed incorrectly and cause invalid logic:

Line 1: Incorrect format of Key-Value pair (missing equals sign). Should be <key = value>, but was: [fruits] # comment. If you wanted to define table - use brackets []

Entry points to fix it: TomlParser.parseStringsToTomlTree

@orchestr7 orchestr7 added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers refactoring labels Feb 11, 2022
@orchestr7 orchestr7 pinned this issue Feb 19, 2022
@orchestr7 orchestr7 linked a pull request Feb 20, 2022 that will close this issue
@orchestr7 orchestr7 self-assigned this Mar 16, 2022
@orchestr7 orchestr7 unpinned this issue Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed refactoring
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant