Deprecations Handling Improvements with v7.16.0 (for PHPUnit 9)

[crynobone]

The upcoming release will introduce Deprecation Handling Improvements and may cause your packages CI to start failing especially if you have configured phpunit.xml configuration with convertDeprecationsToExceptions="true".

In the past, Illuminate\Foundation\Bootstrap\HandleExceptions handles all errors including E_DEPRECATED and E_USER_DEPRECATED and convert it into logs. This works great to reduce deprecation warnings during development but isn't useful for Packages development where you want to actually see the deprecation warnings/exceptions.

Coming with 7.16.0, you should be able to do the following:

convertDeprecationsToExceptions="false"

Output to Spatie Ray

In order to do this, you just need to add the following environment variables to phpunit.xml or CI pipeline:

<env name="SEND_DEPRECATED_NOTICES_TO_RAY" value="(true)" />

Output deprecations logs to stderr

You can also setup Laravel's logger to output deprecation warnings to specific logger channel such as stderr:

<env name="LOG_DEPRECATIONS_CHANNEL" value="stderr" />

Throws using Laravel's exception.

This would throws Orchestra\Testbench\Exceptions\DeprecatedException when you add the following environment variable:

TESTBENCH_CONVERT_DEPRECATIONS_TO_EXCEPTIONS=true

convertDeprecationsToExceptions="true"

By default, all deprecation exception will throws Orchestra\Testbench\Exceptions\DeprecatedException instead of PHPUnit\Framework\Error\Deprecated. Setting TESTBENCH_CONVERT_DEPRECATIONS_TO_EXCEPTIONS environment variable to true has no additional affect.

Completely exclude throwing exceptions

There might be CI build where you might want to exclude throwing deprecation exceptions such as --prefer-lowest builds. In this cause you may add the following environment variable to the build:

TESTBENCH_CONVERT_DEPRECATIONS_TO_EXCEPTIONS=false

[mfn]

Just today I was investigating this (whilst preparing my package for PHP 8.4) and I'm currently super confused how things are supposed to be handled.

What I (think) I know:

• phpunit has built-in support for detecting deprecations (I summarized this a bit in How to check for deprecations with PHPUnit tests laravel/framework#45531 )
• but "the phpunit way" (with that I mean: marking a test with a D for example, or adhering to displayDetailsOnTestsThatTriggerDeprecations) does not seem to work because of Laravels built-in handling

So recommendations like using LOG_DEPRECATIONS_CHANNEL=errorlog (or stderr) are suggested. Is this the expected replacement for this?

Using this I noticed such logging produces a stacktrace on every hit, which isn't really useful (the message contains the source of the PHP deprecation trigger) but I can't turn off trace logging, see e.g. https://github.com/orchestral/testbench-core/blob/9.x/src/Bootstrap/HandleExceptions.php#L62

---

Maybe I'm also mixing things up, but is there a way doing things "the phpunit way" or is "enabling sideband logging during tests" the way forward with Laravel here?

thanks!

[mfn]

https://github.com/laravel/sanctum/actions/runs/11815037934/job/32915353601?pr=542

Actually, your PR example is exactly showing the problem I'm trying to understand.

Solely using PHP 8.4 here

+ $ php -v
PHP 8.4.1-dev (cli) (built: Nov 20 2024 22:24:43) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.4.1-dev, Copyright (c) Zend Technologies
    with Zend OPcache v8.4.1-dev, Copyright (c), by Zend Technologies

I used the current head of the 4.3 branch ( laravel/sanctum@6fa9c8e )

When I just run the tests, I see deprecations upfront, but this is outside of phpunit:

$ vendor/bin/phpunit
PHP Deprecated:  Laravel\Sanctum\HasApiTokens::createToken(): Implicitly marking parameter $expiresAt as nullable is deprecated, the explicit nullable type must be used instead in /Users/neo/src/laravel-sanctum/src/HasApiTokens.php on line 49

Deprecated: Laravel\Sanctum\HasApiTokens::createToken(): Implicitly marking parameter $expiresAt as nullable is deprecated, the explicit nullable type must be used instead in /Users/neo/src/laravel-sanctum/src/HasApiTokens.php on line 49
PHP Deprecated:  Laravel\Sanctum\Contracts\HasApiTokens::createToken(): Implicitly marking parameter $expiresAt as nullable is deprecated, the explicit nullable type must be used instead in /Users/neo/src/laravel-sanctum/src/Contracts/HasApiTokens.php on line 32

Deprecated: Laravel\Sanctum\Contracts\HasApiTokens::createToken(): Implicitly marking parameter $expiresAt as nullable is deprecated, the explicit nullable type must be used instead in /Users/neo/src/laravel-sanctum/src/Contracts/HasApiTokens.php on line 32
PHPUnit 10.5.38 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.4.1-dev
Configuration: /Users/neo/src/laravel-sanctum/phpunit.xml.dist

................................................................. 65 / 70 ( 92%)
.....                                                             70 / 70 (100%)

Time: 00:01.223, Memory: 42.50 MB

OK (70 tests, 164 assertions)

Why? IDK. Because these are not all…

Now I ran it with your example and there is no difference:

$ vendor/bin/phpunit --display-deprecations --fail-on-deprecation
PHP Deprecated:  Laravel\Sanctum\HasApiTokens::createToken(): Implicitly marking parameter $expiresAt as nullable is deprecated, the explicit nullable type must be used instead in /Users/neo/src/laravel-sanctum/src/HasApiTokens.php on line 49

Deprecated: Laravel\Sanctum\HasApiTokens::createToken(): Implicitly marking parameter $expiresAt as nullable is deprecated, the explicit nullable type must be used instead in /Users/neo/src/laravel-sanctum/src/HasApiTokens.php on line 49
PHP Deprecated:  Laravel\Sanctum\Contracts\HasApiTokens::createToken(): Implicitly marking parameter $expiresAt as nullable is deprecated, the explicit nullable type must be used instead in /Users/neo/src/laravel-sanctum/src/Contracts/HasApiTokens.php on line 32

Deprecated: Laravel\Sanctum\Contracts\HasApiTokens::createToken(): Implicitly marking parameter $expiresAt as nullable is deprecated, the explicit nullable type must be used instead in /Users/neo/src/laravel-sanctum/src/Contracts/HasApiTokens.php on line 32
PHPUnit 10.5.38 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.4.1-dev
Configuration: /Users/neo/src/laravel-sanctum/phpunit.xml.dist

................................................................. 65 / 70 ( 92%)
.....                                                             70 / 70 (100%)

Time: 00:01.662, Memory: 42.50 MB

OK (70 tests, 164 assertions)

And now run it with the deprecation logger enabled:

$ LOG_DEPRECATIONS_CHANNEL=errorlog vendor/bin/phpunit
PHP Deprecated:  Laravel\Sanctum\HasApiTokens::createToken(): Implicitly marking parameter $expiresAt as nullable is deprecated, the explicit nullable type must be used instead in /Users/neo/src/laravel-sanctum/src/HasApiTokens.php on line 49

Deprecated: Laravel\Sanctum\HasApiTokens::createToken(): Implicitly marking parameter $expiresAt as nullable is deprecated, the explicit nullable type must be used instead in /Users/neo/src/laravel-sanctum/src/HasApiTokens.php on line 49
PHP Deprecated:  Laravel\Sanctum\Contracts\HasApiTokens::createToken(): Implicitly marking parameter $expiresAt as nullable is deprecated, the explicit nullable type must be used instead in /Users/neo/src/laravel-sanctum/src/Contracts/HasApiTokens.php on line 32

Deprecated: Laravel\Sanctum\Contracts\HasApiTokens::createToken(): Implicitly marking parameter $expiresAt as nullable is deprecated, the explicit nullable type must be used instead in /Users/neo/src/laravel-sanctum/src/Contracts/HasApiTokens.php on line 32
PHPUnit 10.5.38 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.4.1-dev
Configuration: /Users/neo/src/laravel-sanctum/phpunit.xml.dist

[2024-11-21 06:49:20] testing.WARNING: ErrorException: Laravel\Sanctum\Guard::isValidBearerToken(): Implicitly marking parameter $token as nullable is deprecated, the explicit nullable type must be used instead in /Users/neo/src/laravel-sanctum/src/Guard.php:131
Stack trace:
#0 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Support/helpers.php(507): Illuminate\Foundation\Bootstrap\HandleExceptions->{closure:Illuminate\Foundation\Bootstrap\HandleExceptions::handleDeprecationError():103}(Object(Illuminate\Log\Logger))
#1 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/HandleExceptions.php(103): with(Object(Illuminate\Log\Logger), Object(Closure))
#2 /Users/neo/src/laravel-sanctum/vendor/orchestra/testbench-core/src/Bootstrap/HandleExceptions.php(24): Illuminate\Foundation\Bootstrap\HandleExceptions->handleDeprecationError('Laravel\\Sanctum...', '/Users/neo/src/...', 131, 8192)
#3 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/HandleExceptions.php(72): Orchestra\Testbench\Bootstrap\HandleExceptions->handleDeprecationError('Laravel\\Sanctum...', '/Users/neo/src/...', 131, 8192)
#4 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/HandleExceptions.php(256): Illuminate\Foundation\Bootstrap\HandleExceptions->handleError(8192, 'Laravel\\Sanctum...', '/Users/neo/src/...', 131)
#5 /Users/neo/src/laravel-sanctum/vendor/composer/ClassLoader.php(576): Illuminate\Foundation\Bootstrap\HandleExceptions->{closure:Illuminate\Foundation\Bootstrap\HandleExceptions::forwardsTo():255}(8192, 'Laravel\\Sanctum...', '/Users/neo/src/...', 131)
#6 /Users/neo/src/laravel-sanctum/vendor/composer/ClassLoader.php(576): include('/Users/neo/src/...')
#7 /Users/neo/src/laravel-sanctum/vendor/composer/ClassLoader.php(427): {closure:Composer\Autoload\ClassLoader::initializeIncludeClosure():575}('/Users/neo/src/...')
#8 /Users/neo/src/laravel-sanctum/src/SanctumServiceProvider.php(106): Composer\Autoload\ClassLoader->loadClass('Laravel\\Sanctum...')
#9 /Users/neo/src/laravel-sanctum/src/SanctumServiceProvider.php(89): Laravel\Sanctum\SanctumServiceProvider->createGuard(Object(Illuminate\Auth\AuthManager), Array)
#10 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Auth/AuthManager.php(113): Laravel\Sanctum\SanctumServiceProvider->{closure:{closure:Laravel\Sanctum\SanctumServiceProvider::configureGuard():87}:88}(Object(Illuminate\Foundation\Application), 'sanctum', Array)
#11 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Auth/AuthManager.php(90): Illuminate\Auth\AuthManager->callCustomCreator('sanctum', Array)
#12 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Auth/AuthManager.php(70): Illuminate\Auth\AuthManager->resolve('sanctum')
#13 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Auth/Middleware/Authenticate.php(83): Illuminate\Auth\AuthManager->guard('sanctum')
#14 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Auth/Middleware/Authenticate.php(62): Illuminate\Auth\Middleware\Authenticate->authenticate(Object(Illuminate\Http\Request), Array)
#15 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): Illuminate\Auth\Middleware\Authenticate->handle(Object(Illuminate\Http\Request), Object(Closure), 'sanctum')
#16 /Users/neo/src/laravel-sanctum/src/Http/Middleware/EnsureFrontendRequestsAreStateful.php(25): Illuminate\Pipeline\Pipeline->{closure:{closure:Illuminate\Pipeline\Pipeline::carry():158}:159}(Object(Illuminate\Http\Request))
#17 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(144): Laravel\Sanctum\Http\Middleware\EnsureFrontendRequestsAreStateful->{closure:Laravel\Sanctum\Http\Middleware\EnsureFrontendRequestsAreStateful::handle():24}(Object(Illuminate\Http\Request))
#18 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(119): Illuminate\Pipeline\Pipeline->{closure:Illuminate\Pipeline\Pipeline::prepareDestination():142}(Object(Illuminate\Http\Request))
#19 /Users/neo/src/laravel-sanctum/src/Http/Middleware/EnsureFrontendRequestsAreStateful.php(24): Illuminate\Pipeline\Pipeline->then(Object(Closure))
#20 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): Laravel\Sanctum\Http\Middleware\EnsureFrontendRequestsAreStateful->handle(Object(Illuminate\Http\Request), Object(Closure))
#21 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(119): Illuminate\Pipeline\Pipeline->{closure:{closure:Illuminate\Pipeline\Pipeline::carry():158}:159}(Object(Illuminate\Http\Request))
#22 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Routing/Router.php(807): Illuminate\Pipeline\Pipeline->then(Object(Closure))
#23 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Routing/Router.php(786): Illuminate\Routing\Router->runRouteWithinStack(Object(Illuminate\Routing\Route), Object(Illuminate\Http\Request))
#24 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Routing/Router.php(750): Illuminate\Routing\Router->runRoute(Object(Illuminate\Http\Request), Object(Illuminate\Routing\Route))
#25 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Routing/Router.php(739): Illuminate\Routing\Router->dispatchToRoute(Object(Illuminate\Http\Request))
#26 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(201): Illuminate\Routing\Router->dispatch(Object(Illuminate\Http\Request))
#27 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(144): Illuminate\Foundation\Http\Kernel->{closure:Illuminate\Foundation\Http\Kernel::dispatchToRouter():198}(Object(Illuminate\Http\Request))
#28 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php(21): Illuminate\Pipeline\Pipeline->{closure:Illuminate\Pipeline\Pipeline::prepareDestination():142}(Object(Illuminate\Http\Request))
#29 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/ConvertEmptyStringsToNull.php(31): Illuminate\Foundation\Http\Middleware\TransformsRequest->handle(Object(Illuminate\Http\Request), Object(Closure))
#30 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): Illuminate\Foundation\Http\Middleware\ConvertEmptyStringsToNull->handle(Object(Illuminate\Http\Request), Object(Closure))
#31 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php(21): Illuminate\Pipeline\Pipeline->{closure:{closure:Illuminate\Pipeline\Pipeline::carry():158}:159}(Object(Illuminate\Http\Request))
#32 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TrimStrings.php(51): Illuminate\Foundation\Http\Middleware\TransformsRequest->handle(Object(Illuminate\Http\Request), Object(Closure))
#33 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): Illuminate\Foundation\Http\Middleware\TrimStrings->handle(Object(Illuminate\Http\Request), Object(Closure))
#34 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Http/Middleware/ValidatePostSize.php(27): Illuminate\Pipeline\Pipeline->{closure:{closure:Illuminate\Pipeline\Pipeline::carry():158}:159}(Object(Illuminate\Http\Request))
#35 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): Illuminate\Http\Middleware\ValidatePostSize->handle(Object(Illuminate\Http\Request), Object(Closure))
#36 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/PreventRequestsDuringMaintenance.php(110): Illuminate\Pipeline\Pipeline->{closure:{closure:Illuminate\Pipeline\Pipeline::carry():158}:159}(Object(Illuminate\Http\Request))
#37 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): Illuminate\Foundation\Http\Middleware\PreventRequestsDuringMaintenance->handle(Object(Illuminate\Http\Request), Object(Closure))
#38 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Http/Middleware/HandleCors.php(49): Illuminate\Pipeline\Pipeline->{closure:{closure:Illuminate\Pipeline\Pipeline::carry():158}:159}(Object(Illuminate\Http\Request))
#39 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): Illuminate\Http\Middleware\HandleCors->handle(Object(Illuminate\Http\Request), Object(Closure))
#40 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Http/Middleware/TrustProxies.php(58): Illuminate\Pipeline\Pipeline->{closure:{closure:Illuminate\Pipeline\Pipeline::carry():158}:159}(Object(Illuminate\Http\Request))
#41 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): Illuminate\Http\Middleware\TrustProxies->handle(Object(Illuminate\Http\Request), Object(Closure))
#42 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/InvokeDeferredCallbacks.php(22): Illuminate\Pipeline\Pipeline->{closure:{closure:Illuminate\Pipeline\Pipeline::carry():158}:159}(Object(Illuminate\Http\Request))
#43 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): Illuminate\Foundation\Http\Middleware\InvokeDeferredCallbacks->handle(Object(Illuminate\Http\Request), Object(Closure))
#44 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(119): Illuminate\Pipeline\Pipeline->{closure:{closure:Illuminate\Pipeline\Pipeline::carry():158}:159}(Object(Illuminate\Http\Request))
#45 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(176): Illuminate\Pipeline\Pipeline->then(Object(Closure))
#46 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(145): Illuminate\Foundation\Http\Kernel->sendRequestThroughRouter(Object(Illuminate\Http\Request))
#47 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Foundation/Testing/Concerns/MakesHttpRequests.php(604): Illuminate\Foundation\Http\Kernel->handle(Object(Illuminate\Http\Request))
#48 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Foundation/Testing/Concerns/MakesHttpRequests.php(570): Orchestra\Testbench\TestCase->call('GET', '/sanctum/api/us...', Array, Array, Array, Array, '[]')
#49 /Users/neo/src/laravel-sanctum/vendor/laravel/framework/src/Illuminate/Foundation/Testing/Concerns/MakesHttpRequests.php(378): Orchestra\Testbench\TestCase->json('GET', '/sanctum/api/us...', Array, Array, 0)
#50 /Users/neo/src/laravel-sanctum/tests/Controller/AuthenticateRequestsTest.php(54): Orchestra\Testbench\TestCase->getJson('/sanctum/api/us...', Array)
#51 /Users/neo/src/laravel-sanctum/vendor/phpunit/phpunit/src/Framework/TestCase.php(1188): Laravel\Sanctum\Tests\Controller\AuthenticateRequestsTest->test_can_authorize_valid_user_using_authorization_header()
#52 /Users/neo/src/laravel-sanctum/vendor/phpunit/phpunit/src/Framework/TestCase.php(687): PHPUnit\Framework\TestCase->runTest()
#53 /Users/neo/src/laravel-sanctum/vendor/phpunit/phpunit/src/Framework/TestRunner.php(106): PHPUnit\Framework\TestCase->runBare()
#54 /Users/neo/src/laravel-sanctum/vendor/phpunit/phpunit/src/Framework/TestCase.php(517): PHPUnit\Framework\TestRunner->run(Object(Laravel\Sanctum\Tests\Controller\AuthenticateRequestsTest))
#55 /Users/neo/src/laravel-sanctum/vendor/phpunit/phpunit/src/Framework/TestSuite.php(374): PHPUnit\Framework\TestCase->run()
#56 /Users/neo/src/laravel-sanctum/vendor/phpunit/phpunit/src/Framework/TestSuite.php(374): PHPUnit\Framework\TestSuite->run()
#57 /Users/neo/src/laravel-sanctum/vendor/phpunit/phpunit/src/Framework/TestSuite.php(374): PHPUnit\Framework\TestSuite->run()
#58 /Users/neo/src/laravel-sanctum/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(64): PHPUnit\Framework\TestSuite->run()
#59 /Users/neo/src/laravel-sanctum/vendor/phpunit/phpunit/src/TextUI/Application.php(203): PHPUnit\TextUI\TestRunner->run(Object(PHPUnit\TextUI\Configuration\Configuration), Object(PHPUnit\Runner\ResultCache\DefaultResultCache), Object(PHPUnit\Framework\TestSuite))
#60 /Users/neo/src/laravel-sanctum/vendor/phpunit/phpunit/phpunit(104): PHPUnit\TextUI\Application->run(Array)
#61 /Users/neo/src/laravel-sanctum/vendor/bin/phpunit(122): include('/Users/neo/src/...')
#62 {main}

................................................................. 65 / 70 ( 92%)
.....                                                             70 / 70 (100%)

Time: 00:01.215, Memory: 42.50 MB

OK (70 tests, 164 assertions)

This now shows one additional deprecation warning we did not see before!

• I don't now why "pure PHP deprecations" are shown even before PHPUnit starts
• We see the additional PHP deprecation during the tests only because we enabled the Laravel specific deprecation logger
• The pure PHPUnit based deprecation detection / behaviour is not triggered, even with LOG_DEPRECATIONS_CHANNEL=errorlog vendor/bin/phpunit --display-deprecations --fail-on-deprecation the suite passes

I hope I could better explain my confusion.

WDYT?

[crynobone]

My current recommendation is and will be to use the following:

vendor/bin/phpunit --display-deprecations --fail-on-deprecation

I am not interested in going into a discussion on the internal and what had to been done for PHPUnit 9

[mfn]

Fair point and I didn't mean to steal anyones time.

But for Laravel projects that is not sufficient, as I've shown.

[crynobone]

Testbench is for Laravel Packages and not Laravel testing.

[mfn]

I am talking about Laravel packages (as is sanctum from your example, as is the project I discovered this https://github.com/rebing/graphql-laravel ).

I'm not blaming orchestra in any way, in fact, I don't even think it's at fault at all.

Your discussion messsage about deprecation handling here is basically one of two links I found with google related to the problem that I initially was not seeing the deprecations at all.

I don't know how it behaves with actual Laravel projects, I was only talking about Packages.

But you helped me understand more on that matter, much appreciated 🙏🏼