Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Tests failing when directive does not have inputs and outputs #3

Open
gund opened this issue Apr 16, 2019 · 0 comments
Open

[Bug] Tests failing when directive does not have inputs and outputs #3

gund opened this issue Apr 16, 2019 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@gund
Copy link
Member

gund commented Apr 16, 2019

In this case angular does not create property ngBaseDef on the directive class and thus consequent property accesses fail here:

export function getDirectiveIO<T>(dirType: Type<T>): DirectiveIO {
const { inputs, outputs } = (dirType as any).ngBaseDef;

This access has to be guarded.

@gund gund added the bug Something isn't working label Apr 16, 2019
@gund gund self-assigned this Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant