Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make --fee-rate a mandatory argument for wallet send #1747

Closed
veryordinally opened this issue Feb 15, 2023 · 3 comments
Closed

Make --fee-rate a mandatory argument for wallet send #1747

veryordinally opened this issue Feb 15, 2023 · 3 comments

Comments

@veryordinally
Copy link
Collaborator

veryordinally commented Feb 15, 2023 •
edited
Loading

Per suggestion from RarePepeMaximalist.

Lots of transaction getting stuck in mempool at default 1sat/vByte, which we may never see clear again.

I think it'd be better to make --fee-rate a required parameter. Ord users will have to learn about fee market anyways.
@veryordinally veryordinally changed the title Make --fee-rate' a mandatory argument for wallet send' Make --fee-rate a mandatory argument for wallet send Feb 15, 2023
@veryordinally veryordinally mentioned this issue Feb 15, 2023
Merged
3 tasks
@raphjaph
Copy link
Collaborator

Merging #1755 which will make --fee-rate mandatory. For this issue to be closed we need it for wallet inscribe as well.

@casey
Copy link
Collaborator

casey commented Feb 15, 2023

Partially fixed by #1755. Closing in favor of #1432, which has details on a full fix.

@casey casey closed this as completed Feb 15, 2023
@veryordinally veryordinally changed the title Make --fee-rate a mandatory argument for wallet send Make --fee-rate a mandatory argument for wallet send and wallet inscribe Feb 16, 2023
@veryordinally veryordinally changed the title Make --fee-rate a mandatory argument for wallet send and wallet inscribe Make --fee-rate a mandatory argument for wallet send Feb 16, 2023
@veryordinally veryordinally mentioned this issue Feb 16, 2023
Closed
@veryordinally
Copy link
Collaborator Author

Created follow up issue #1767 for the wallet inscribe part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@casey @veryordinally @raphjaph