feat(minor): Add support for CI detection of absolute threshold improvements + signposts for Instruments #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
==========================================
- Coverage 71.70% 71.14% -0.56%
==========================================
Files 27 29 +2
Lines 3551 3652 +101
==========================================
+ Hits 2546 2598 +52
- Misses 1005 1054 +49
Continue to review full report in Codecov by Sentry.
|
|
Pull request benchmark comparison [ubuntu-latest] with 'main' run at 2023-09-13T18:03:26+00:00 |
hassila
changed the title
dimlio
approved these changes
Sep 11, 2023
## Description Delta for retain/release was misleading as initial retain count from alloc wasn't included, added new objectAllocCount metric. Other refactoring/cleanup. ## How Has This Been Tested? Manual testing + test suite. ## Minimal checklist: - [x] I have performed a self-review of my own code - [ ] I have added `DocC` code-level documentation for any public interfaces exported by the package - [ ] I have added unit and/or integration tests that prove my fix is effective or that my feature works
dimlio
approved these changes
Sep 13, 2023
Co-authored-by: dimlio <122263440+dimlio@users.noreply.github.com>
Co-authored-by: dimlio <122263440+dimlio@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Its desirable to be able to signal from CI if a threshold has been improved too and not only regressed, so we now return exit code 0 only for exact equal checks and 2 for regressions and 4 for improvements.
Added support for signposts (#183):
Added new objectAllocCount ARC stat counter and fixed the delta calculation to take initial refcount into account.
Also added support for returning setupState from the benchmark setup hooks, to allow access to state that can be reused per benchmark iteration.
How Has This Been Tested?
Manually tested + added unit test.
Minimal checklist:
DocCcode-level documentation for any public interfaces exported by the package