Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(minor): Avoid rebuilds #207

Merged
merged 5 commits into from
Dec 15, 2023
Merged

feat(minor): Avoid rebuilds #207

merged 5 commits into from
Dec 15, 2023

Conversation

hassila
Copy link
Contributor

@hassila hassila commented Dec 14, 2023

Description

We used to unconditionally build all benchmark targets regardless of operation.

Changed logic so that we for baseline read/list/check operations don't rebuild, as we will not execute the benchmark for such operations.

How Has This Been Tested?

Manually tested.

Minimal checklist:

  • I have performed a self-review of my own code
  • I have added DocC code-level documentation for any public interfaces exported by the package
  • I have added unit and/or integration tests that prove my fix is effective or that my feature works

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #207 (23a32fd) into main (dba4133) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #207   +/-   ##
=======================================
  Coverage   70.40%   70.40%           
=======================================
  Files          29       29           
  Lines        3909     3909           
=======================================
  Hits         2752     2752           
  Misses       1157     1157           
Files Coverage Δ
Tests/BenchmarkTests/AdditionalTests.swift 100.00% <100.00%> (ø)
Files Coverage Δ
Tests/BenchmarkTests/AdditionalTests.swift 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dba4133...23a32fd. Read the comment docs.

Copy link
Contributor

github-actions bot commented Dec 14, 2023

@hassila hassila requested a review from dimlio December 14, 2023 09:22
@hassila hassila merged commit 05695c9 into main Dec 15, 2023
@hassila hassila deleted the dont-rebuild branch December 15, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants