You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In testing the new updateLanguage methods added in v2.8.0 I noticed that strings using custom data-cc attributes don't have their click handlers attached.
The specific use case I had was for the consent_modal.description text where I have a button with data-cc="c-settings" (same as the demo app).
This button stops functioning and does not open the settings modal after calling the updateLanguage method.
Is it safe to call _addDataButtonListeners after the language change, or do we need to keep track of already hydrated elements to prevent duplicate event listeners?
I can provide a PR, but will probably not be in time for the v2.8 release tag.
Thanks again!
The text was updated successfully, but these errors were encountered:
Hi, and thanks for this library 💖
In testing the new
updateLanguage
methods added in v2.8.0 I noticed that strings using customdata-cc
attributes don't have their click handlers attached.The specific use case I had was for the
consent_modal.description
text where I have a button withdata-cc="c-settings"
(same as the demo app).This button stops functioning and does not open the settings modal after calling the
updateLanguage
method.Is it safe to call
_addDataButtonListeners
after the language change, or do we need to keep track of already hydrated elements to prevent duplicate event listeners?I can provide a PR, but will probably not be in time for the v2.8 release tag.
Thanks again!
The text was updated successfully, but these errors were encountered: