Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: In translated / i18n projects, the config dialog does not work in the second language #693

Closed
ascheucher-shopify-partner opened this issue Jun 5, 2024 · 3 comments
Labels
invalid This doesn't seem right stale

Comments

@ascheucher-shopify-partner

Expected Behavior

In Astro projects with i18n support, the configuration dialog should work in all languages.

Config dialog working

Current Behavior

Switching to the non default language, there are no buttons and no heading styling for the sections in the config dialog.

Config dialog broken

Steps to reproduce

I have created a minimal Astro project with DE & EN support on StackBlitz

  • open the minimal project
  • wait for it to build and let it load the working EN version of the page
  • open the preferences to see it working
  • close the preferences
  • click the switch to DE link below the welcome to Astro heading
  • click the Einstellungen button to see the broken dialog

Proposed fix or additional info.

Sorry, I don't have any suggestion on how to solve the issue.

Thanks for having a look.

Version

3.0.1

On which browser do you see the issue?

Chrome

@ascheucher-shopify-partner ascheucher-shopify-partner added the bug Something isn't working label Jun 5, 2024
@github-actions github-actions bot added the triage yet to be reviewed label Jun 5, 2024
@ascheucher-shopify-partner
Copy link
Author

Ah, want to add:

Comparing the DOM in the EN and DE version of the open settings dialog, there are some nodes missing in the DE version.

@orestbida
Copy link
Owner

The configuration for the de translation is not correct. You should not translate the "linkedCategory" value, as that is used to reference a specific category.

By translating it, it's no longer able to find a valid category, and just renders a normal section block.

@orestbida orestbida added invalid This doesn't seem right and removed bug Something isn't working triage yet to be reviewed labels Jun 6, 2024
Copy link

stale bot commented Jul 6, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 6, 2024
@stale stale bot closed this as completed Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right stale
Projects
None yet
Development

No branches or pull requests

2 participants