Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Play, Huawei Appgallery links doesn't work at https://organicmaps.app/support-us/ in desktop browser #21

Open
dbf256 opened this issue Nov 24, 2021 · 6 comments · May be fixed by #186
Labels
bug Something isn't working

Comments

@dbf256
Copy link

dbf256 commented Nov 24, 2021

<a href="market://details?id=app.organicmaps">Google Play</a>,
<a href="appmarket://details?id=app.organicmaps">Huawei Appgallery</a>

It is handled by mobile browser, but doesn't work on a desktop, maybe add some fallback?

@biodranik
Copy link
Member

A JS code that detects desktops (is it already on the site?) and replaces links with something else?

@oleg-rswll oleg-rswll added the bug Something isn't working label Sep 19, 2023
@reinhart1010
Copy link

reinhart1010 commented Sep 22, 2023

Is there a reason for not using web URLs (e.g. https://play.google.com/) in the first place?

@biodranik
Copy link
Member

Do web urls open reviews exactly in the same way as market urls?

@reinhart1010
Copy link

The market:// and appmarket:// urls are actually URIs which do not correspond to an Internet service (e.g. Google Play or OpenStreetMap), and it means different OSes will intepret how these links are handled.

In Android, Google Play Store and F-Droid are some of the apps that can open and intepret the market:// URIs. But others like Windows and iOS will look for installed apps that can open and interpret this URI, and if there isn't one, they will fail.

Replacing these links to web URLs (like https://play.google.com) will do, and speaking of privacy, users of these app stores should not bother with the change as they already accepted the terms in their respective app store apps.

reinhart1010 added a commit to reinhart1010/organicmaps.github.io that referenced this issue Oct 7, 2023
This commit fixes organicmaps#21 by replacing app store-specific URIs into website URLs which can be viewed by most platforms.
@biodranik
Copy link
Member

biodranik commented Oct 8, 2023

What is actually needed:

  1. Show market:// and other URL schemes only to android users.
  2. Show https:// links for all other operating systems.

Can you please help to implement that?

@biodranik
Copy link
Member

Check the JS example at this page (see at the bottom): https://omaps.app/api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants