lbdb 0.49.1 does not include khard support

[arponero]

Hi all,

After upgrading to 0.49.1, I just noticed that lbdbq does not search in my khard database anymore. The output shows the following:
/usr/local/bin/lbdbq: line 75: m_khard_query: command not found

And, actually, the m_khard module is not in lib/lbdb.

The original source does include the khard module, so I had to manually download the source, configure, make and make install it, and everything is working fine now.

Best,
Jaime

[SMillerDev]

I'm guessing this is about a formula instead of a cask since you managed to install it from source.

In which case, could you make a pull request to make the formula do that too?

[SMillerDev]

You can submit your changes as a draft pull request and maybe I can help you get it fixed from there. It's much easier to debug with CI running.

[gwarf]

OK @SMillerDev, will do this, thanks!

[gwarf]

Here is the PR, thanks: Homebrew/homebrew-core#181760.
Thanks to the PR template, apparently I was just missing a parameter:

brew reinstall --build-from-source lbdb
ls /usr/local/Cellar/lbdb/0.54/lib/lbdb/
ABQuery                 m_fido                  m_osx_addressbook       palm_lsaddr
fetchaddr               m_finger                m_palm                  qpto8bit
lbdb-munge              m_gnomecard             m_passwd                tac
lbdb_bbdb_query.el      m_inmail                m_pine                  vcquery
lbdb_lib                m_khard                 m_vcf
m_abook                 m_ldap                  m_wanderlust
m_bbdb                  m_muttalias             munge

Maybe --build-fomr-source should be specified in https://docs.brew.sh/FAQ#can-i-edit-formulae-myself? Or is it due to some other issue on my side?

[gromgit]

Maybe --build-fomr-souce should be specified in https://docs.brew.sh/FAQ#can-i-edit-formulae-myself?

It will be.

[gwarf]

Cool, thanks @gromgit!