Restoring subliminal formulae

[woj-tek]

Output of brew config

n/a

Output of brew doctor

n/a

Description of issue

Hi, from what I can see, subliminal formulae was removed in commit Homebrew/homebrew-core@d73a4fe as a result of this PR: Homebrew/homebrew-core#171324 that removed outdated formula and indeed last seen version (https://github.com/Homebrew/homebrew-core/blob/adb4374422571adc4b7d1af5da64a5a526cdfc33/Formula/s/subliminal.rb) had this

https://github.com/Homebrew/homebrew-core/blob/adb4374422571adc4b7d1af5da64a5a526cdfc33/Formula/s/subliminal.rb#L23C1-L24C54:

  # https://github.com/Diaoul/subliminal/issues/1046
  disable! date: "2023-05-09", because: :unmaintained

As a result of this issue Homebrew/homebrew-core#98770 by @iMichka

Now to the point - in the meantime subliminal got new maintainers (Diaoul/subliminal#1064) and it just released new version: https://github.com/Diaoul/subliminal/releases/tag/2.2.0

Would it be ok to restore it's formula?

[SMillerDev]

You can submit it as a new formula, the docs for that are here: https://docs.brew.sh/Adding-Software-to-Homebrew

[woj-tek]

@SMillerDev OK, so I got it running (install nice and all) but I'm stuck with audit:

wojtek@atlantiscity.local /opt/homebrew/Library/Taps/homebrew/homebrew-core $ brew audit --strict --new --online subliminal
subliminal
  * HEAD: Use `branch: "main"` to specify the default branch
  * New formulae in homebrew/core should not have a `bottle do` block
  * New formulae should not define a revision.
Error: 3 problems in 1 formula detected.

Given that I based it on the previously existing formula I'm not sure how to proceed:

• should I treat it as new formula and just remove revision?
• similarly I don't know what to do with "bottle do" section - just get rid of it?

Here's the formula - so far (I'll make a PR once I know how to make audit pass):

class Subliminal < Formula
  include Language::Python::Virtualenv

  desc "Library to search and download subtitles"
  homepage "https://subliminal.readthedocs.io"
  url "https://files.pythonhosted.org/packages/32/07/9ea2a7d67fbcc8ff132d72d6162548ad19b742a0350ddf2b82fe8a18a34e/subliminal-2.2.0.tar.gz"
  sha256 "f103380d1e2ef09b7cb194beff5bf4a19492d5f3bbf336dec03a7451c992a593"
  license "MIT"
  revision 2
  head "https://github.com/Diaoul/subliminal.git", branch: "master"

  bottle do
    rebuild 1
    sha256 cellar: :any_skip_relocation, arm64_ventura:  "aceffa16fd3c0ef9dd59807dd2144a55c7291846b4d85100811ce5de7b7ca5a4"
    sha256 cellar: :any_skip_relocation, arm64_monterey: "4e71db9ee5661b99f756281a8683affe6d239c01c4f168e56fdea76a939e1fdb"
    sha256 cellar: :any_skip_relocation, arm64_big_sur:  "93417bbdf08ad983d6a2ec5151f043dfbc84408759849ea52d95ddf7d564f6da"
    sha256 cellar: :any_skip_relocation, ventura:        "d871750ece1d220e3fbbb7ce244eb82f7ef9e172b2562369ff73f67be8b60371"
    sha256 cellar: :any_skip_relocation, monterey:       "205cf4a299a71a713c1800a763b1e4db6dbe84231b300e0a76e68e7ec70955e6"
    sha256 cellar: :any_skip_relocation, big_sur:        "452dd79729153b41090bf94487b70d369ffed3769ad23aea7cb78112f770db2a"
    sha256 cellar: :any_skip_relocation, x86_64_linux:   "cbde28668573a72b7572899110d645aca03095d47cd1a77999a626e84e70853d"
  end

  depends_on "python@3.12"

  resource "babelfish" do
    url "https://files.pythonhosted.org/packages/c5/8f/17ff889327f8a1c36a28418e686727dabc06c080ed49c95e3e2424a77aa6/babelfish-0.6.1.tar.gz"
    sha256 "decb67a4660888d48480ab6998309837174158d0f1aa63bebb1c2e11aab97aab"
  end

  resource "beautifulsoup4" do
    url "https://files.pythonhosted.org/packages/b3/ca/824b1195773ce6166d388573fc106ce56d4a805bd7427b624e063596ec58/beautifulsoup4-4.12.3.tar.gz"
    sha256 "74e3d1928edc070d21748185c46e3fb33490f22f52a3addee9aee0f4f7781051"
  end

  resource "certifi" do
    url "https://files.pythonhosted.org/packages/07/b3/e02f4f397c81077ffc52a538e0aec464016f1860c472ed33bd2a1d220cc5/certifi-2024.6.2.tar.gz"
    sha256 "3cd43f1c6fa7dedc5899d69d3ad0398fd018ad1a17fba83ddaf78aa46c747516"
  end

  resource "chardet" do
    url "https://files.pythonhosted.org/packages/f3/0d/f7b6ab21ec75897ed80c17d79b15951a719226b9fababf1e40ea74d69079/chardet-5.2.0.tar.gz"
    sha256 "1b3b6ff479a8c414bc3fa2c0852995695c4a026dcd6d0633b2dd092ca39c1cf7"
  end

  resource "charset-normalizer" do
    url "https://files.pythonhosted.org/packages/63/09/c1bc53dab74b1816a00d8d030de5bf98f724c52c1635e07681d312f20be8/charset-normalizer-3.3.2.tar.gz"
    sha256 "f30c3cb33b24454a82faecaf01b19c18562b1e89558fb6c56de4d9118a032fd5"
  end

  resource "click" do
    url "https://files.pythonhosted.org/packages/96/d3/f04c7bfcf5c1862a2a5b845c6b2b360488cf47af55dfa79c98f6a6bf98b5/click-8.1.7.tar.gz"
    sha256 "ca9853ad459e787e2192211578cc907e7594e294c7ccc834310722b41b9ca6de"
  end

  resource "click-option-group" do
    url "https://files.pythonhosted.org/packages/e7/b8/91054601a2e05fd9060cb1baf56be5b24145817b059e078669e1099529c7/click-option-group-0.5.6.tar.gz"
    sha256 "97d06703873518cc5038509443742b25069a3c7562d1ea72ff08bfadde1ce777"
  end

  resource "colorama" do
    url "https://files.pythonhosted.org/packages/d8/53/6f443c9a4a8358a93a6792e2acffb9d9d5cb0a5cfd8802644b7b1c9a02e4/colorama-0.4.6.tar.gz"
    sha256 "08695f5cb7ed6e0531a20572697297273c47b8cae5a63ffc6d6ed5c201be6e44"
  end

  resource "decorator" do
    url "https://files.pythonhosted.org/packages/66/0c/8d907af351aa16b42caae42f9d6aa37b900c67308052d10fdce809f8d952/decorator-5.1.1.tar.gz"
    sha256 "637996211036b6385ef91435e4fae22989472f9d571faba8927ba8253acbc330"
  end

  resource "dogpile-cache" do
    url "https://files.pythonhosted.org/packages/81/3b/83ce66995ce658ad63b86f7ca83943c466133108f20edc7056d4e0f41347/dogpile.cache-1.3.3.tar.gz"
    sha256 "f84b8ed0b0fb297d151055447fa8dcaf7bae566d4dbdefecdcc1f37662ab588b"
  end

  resource "enzyme" do
    url "https://files.pythonhosted.org/packages/b7/6a/5837b746cdf9653178cb3fd4e22761c6c06c58250f5844180728ee1a8986/enzyme-0.5.1.tar.gz"
    sha256 "d4d86becb2c318a13fd242468be568f6a28192ed39faf8525aeb6cd2aa07ee60"
  end

  resource "guessit" do
    url "https://files.pythonhosted.org/packages/d0/07/5a88020bfe2591af2ffc75841200b2c17ff52510779510346af5477e64cd/guessit-3.8.0.tar.gz"
    sha256 "6619fcbbf9a0510ec8c2c33744c4251cad0507b1d573d05c875de17edc5edbed"
  end

  resource "idna" do
    url "https://files.pythonhosted.org/packages/21/ed/f86a79a07470cb07819390452f178b3bef1d375f2ec021ecfc709fc7cf07/idna-3.7.tar.gz"
    sha256 "028ff3aadf0609c1fd278d8ea3089299412a7a8b9bd005dd08b9f8285bcb5cfc"
  end

  resource "pbr" do
    url "https://files.pythonhosted.org/packages/8d/c2/ee43b3b11bf2b40e56536183fc9f22afbb04e882720332b6276ee2454c24/pbr-6.0.0.tar.gz"
    sha256 "d1377122a5a00e2f940ee482999518efe16d745d423a670c27773dfbc3c9a7d9"
  end

  resource "platformdirs" do
    url "https://files.pythonhosted.org/packages/f5/52/0763d1d976d5c262df53ddda8d8d4719eedf9594d046f117c25a27261a19/platformdirs-4.2.2.tar.gz"
    sha256 "38b7b51f512eed9e84a22788b4bce1de17c0adb134d6becb09836e37d8654cd3"
  end

  resource "pysubs2" do
    url "https://files.pythonhosted.org/packages/1f/72/e9d8ac5aeb431bd49666fb49a6f6cdabfa040917a95a320e0f75d22b694e/pysubs2-1.7.2.tar.gz"
    sha256 "b708904269cb252dbc51de75a372e04ab00c368939bb8220f7b0f940d978725e"
  end

  resource "python-dateutil" do
    url "https://files.pythonhosted.org/packages/d9/77/bd458a2e387e98f71de86dcc2ca2cab64489736004c80bc12b70da8b5488/python-dateutil-2.9.0.tar.gz"
    sha256 "78e73e19c63f5b20ffa567001531680d939dc042bf7850431877645523c66709"
  end

  resource "rarfile" do
    url "https://files.pythonhosted.org/packages/21/20/f07592dcf45f8f88a23c094019008ad220307401214a5c5a4e44d3e93acf/rarfile-2.8.tar.gz"
    sha256 "2a27e401daa6d8ff0df1112a274a3661ca3e4afaac626217506fb1391069ca61"
  end

  resource "rebulk" do
    url "https://files.pythonhosted.org/packages/f2/06/24c69f8d707c9eefc1108a64e079da56b5f351e3f59ed76e8f04b9f3e296/rebulk-3.2.0.tar.gz"
    sha256 "0d30bf80fca00fa9c697185ac475daac9bde5f646ce3338c9ff5d5dc1ebdfebc"
  end

  resource "requests" do
    url "https://files.pythonhosted.org/packages/63/70/2bf7780ad2d390a8d301ad0b550f1581eadbd9a20f896afe06353c2a2913/requests-2.32.3.tar.gz"
    sha256 "55365417734eb18255590a9ff9eb97e9e1da868d4ccd6402399eaf68af20a760"
  end

  resource "six" do
    url "https://files.pythonhosted.org/packages/71/39/171f1c67cd00715f190ba0b100d606d440a28c93c7714febeca8b79af85e/six-1.16.0.tar.gz"
    sha256 "1e61c37477a1626458e36f7b1d82aa5c9b094fa4802892072e49de9c60c4c926"
  end

  resource "soupsieve" do
    url "https://files.pythonhosted.org/packages/ce/21/952a240de1c196c7e3fbcd4e559681f0419b1280c617db21157a0390717b/soupsieve-2.5.tar.gz"
    sha256 "5663d5a7b3bfaeee0bc4372e7fc48f9cff4940b3eec54a6451cc5299f1097690"
  end

  resource "srt" do
    url "https://files.pythonhosted.org/packages/66/b7/4a1bc231e0681ebf339337b0cd05b91dc6a0d701fa852bb812e244b7a030/srt-3.5.3.tar.gz"
    sha256 "4884315043a4f0740fd1f878ed6caa376ac06d70e135f306a6dc44632eed0cc0"
  end

  resource "stevedore" do
    url "https://files.pythonhosted.org/packages/80/a3/7db17f998684ee1c225cfae74ccca4b369118419c07be48991f30e942c31/stevedore-3.5.2.tar.gz"
    sha256 "cf99f41fc0d5a4f185ca4d3d42b03be9011b0a1ec1a4ea1a282be1b4b306dcc2"
  end

  resource "tomli" do
    url "https://files.pythonhosted.org/packages/c0/3f/d7af728f075fb08564c5949a9c95e44352e23dee646869fa104a3b2060a3/tomli-2.0.1.tar.gz"
    sha256 "de526c12914f0c550d15924c62d72abc48d6fe7364aa87328337a31007fe8a4f"
  end

  resource "urllib3" do
    url "https://files.pythonhosted.org/packages/43/6d/fa469ae21497ddc8bc93e5877702dca7cb8f911e337aca7452b5724f1bb6/urllib3-2.2.2.tar.gz"
    sha256 "dd505485549a7a552833da5e6063639d0d177c04f23bc3864e41e5dc5f612168"
  end

  def install
    virtualenv_install_with_resources
  end

  test do
    (testpath/".config").mkpath
    system bin/"subliminal", "download", "-l", "en",
               "The.Big.Bang.Theory.S05E18.HDTV.x264-LOL.mp4"
    assert_predicate testpath/"The.Big.Bang.Theory.S05E18.HDTV.x264-LOL.en.srt", :exist?
  end
end

[SMillerDev]

should I treat it as new formula and just remove revision?
similarly I don't know what to do with "bottle do" section - just get rid of it?

Yes on both questions. As far as I'm concerned this is a completely new formula.

[woj-tek]

Thank you so much for the guidance, PR: Homebrew/homebrew-core#175756

[woj-tek]

@SMillerDev btw is there a tool/script that helps to populate dependency list or it has to be done manually?

[SMillerDev]

brew update-python-resources can be used to update the python resources. Dependencies have to be done manually.