Replies: 3 comments
-
Yeah, its a pretty big change, I vote to bump it to 6.0, and bump sasmodels to 2.0 too.
How would you see this working? An |
Beta Was this translation helpful? Give feedback.
-
Good question :-) Not exactly sure but it seems like it would be relatively straightforward? 😄 Basically yes I guess on keeping dataloader base classes but make them import the sasdata package and then use that instead of the code currently being used? Spoken as someone who has NOT done this kind of thing before clearly... That said we did some kind of ugly shimming I think for sasmodels which is why we still have a sasview sasmodels that does some kind of translation if I remember (and is on the list to be replaced/removed at some point ... indicating perhaps it is not so easy to get rid of :-) |
Beta Was this translation helpful? Give feedback.
-
Converting to a discussion. |
Beta Was this translation helpful? Give feedback.
-
Is your feature request related to a problem? Please describe.
With the merge today of the PR #2141 (and associated sasmodels PR) all scripts using the SasView dataloader are now be broken. There are probably quite a lot of these.
Describe the solution you'd like
This should be a discussion item. Of course we could do nothing (though I'd argue that is bad form). The options I see would be
Having written it out, I now think the last option is the correct option
Describe alternatives you've considered
See above -- discussion item
Additional context
NONE
Beta Was this translation helpful? Give feedback.
All reactions